Skip to content

London | 26-ITP-SEP | Bartosz Kawiak | Sprint 2 | Course-work-2 - #1532

Closed
bartoszkawiak wants to merge 15 commits into
CodeYourFuture:mainfrom
bartoszkawiak:coursework/sprint-2
Closed

bartoszkawiak wants to merge 15 commits into
CodeYourFuture:mainfrom
bartoszkawiak:coursework/sprint-2

Conversation

@bartoszkawiak

@bartoszkawiak bartoszkawiak commented Sep 17, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1039

Changelist

Completed the Sprint 2 JavaScript exercises, including working with variables, strings, methods, operators, function calls, and basic objects. Added answers and explanations to the exercise questions.

@netlify

netlify Bot commented Sep 17, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 349143a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aad0dfd2600520008f4a2be
😎 Deploy Preview https://deploy-preview-1532--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@bartoszkawiak bartoszkawiak added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 17, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

@bartoszkawiak bartoszkawiak changed the title London | 26-ITP-Sep | Bartosz Kawiak | Sprint 2 | Sprint 2 Coursework Completed London | 26-ITP-Sep | Bartosz Kawiak | Sprint 2 | Sprint 2 Coursework Sep 18, 2026
@github-actions

This comment has been minimized.

@bartoszkawiak bartoszkawiak changed the title London | 26-ITP-Sep | Bartosz Kawiak | Sprint 2 | Sprint 2 Coursework London | 26-ITP-Sep | Bartosz Kawiak | Sprint 2 | Coursework 2 Sep 18, 2026
@github-actions

This comment has been minimized.

@bartoszkawiak bartoszkawiak changed the title London | 26-ITP-Sep | Bartosz Kawiak | Sprint 2 | Coursework 2 London | 26-ITP-SEP | Bartosz Kawiak | Sprint 2 | Coursework-2 Sep 18, 2026
@github-actions

This comment has been minimized.

@bartoszkawiak bartoszkawiak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@bartoszkawiak bartoszkawiak changed the title London | 26-ITP-SEP | Bartosz Kawiak | Sprint 2 | Coursework-2 London | 26-ITP-SEP | Bartosz Kawiak | Sprint 2 | Course-work-2 Sep 18, 2026
@github-actions

This comment has been minimized.

@bartoszkawiak bartoszkawiak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026

@abdishakoor-dev abdishakoor-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to fix before I look at the exercises.

You made this branch from your Form Controls branch. It should be made from main. This happens when you forget to switch to main first.

Because of this, five Form Controls commits are part of this PR. That is why the bot kept rejecting it. You removed the Form Controls files this morning. That was the right fix.

The rule: switch to main first, then make your new branch. Do this for every task.

Here is how to redo this branch. You will not lose any work:

git switch main
git pull origin main
git switch -c sprint-2
git cherry-pick 37c2084 ecca7f7 8833f3c abd38ec d6671b9 5196ca3 c806b08
git push --set-upstream origin sprint-2

I tested these commands. All seven commits apply with no errors. The result is the same as what you have now.

Then open a new PR from the new branch. Link to this PR in the description, and close this one. I will review the exercises there.

@abdishakoor-dev abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants