London | 26-ITP-SEP | Bartosz Kawiak | Sprint 2 | Course-work-2 - #1532
bartoszkawiak wants to merge 15 commits into
Conversation
…k/Module-JavaScript-Fundamentals into coursework/sprint-2
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
One thing to fix before I look at the exercises.
You made this branch from your Form Controls branch. It should be made from main. This happens when you forget to switch to main first.
Because of this, five Form Controls commits are part of this PR. That is why the bot kept rejecting it. You removed the Form Controls files this morning. That was the right fix.
The rule: switch to main first, then make your new branch. Do this for every task.
Here is how to redo this branch. You will not lose any work:
git switch main
git pull origin main
git switch -c sprint-2
git cherry-pick 37c2084 ecca7f7 8833f3c abd38ec d6671b9 5196ca3 c806b08
git push --set-upstream origin sprint-2
I tested these commands. All seven commits apply with no errors. The result is the same as what you have now.
Then open a new PR from the new branch. Link to this PR in the description, and close this one. I will review the exercises there.

Learners, PR Template
Self checklist
Task code
CYF-1039
Changelist
Completed the Sprint 2 JavaScript exercises, including working with variables, strings, methods, operators, function calls, and basic objects. Added answers and explanations to the exercise questions.