Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
abmhts
added
the
Needs Review
selyafi
reviewed
Sep 17, 2026
| // This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution. | ||
|
|
||
| const initials = ``; | ||
| const initials = firstName.charAt(0) + middleName.charAt(0) + lastName.charAt(0) |
There was a problem hiding this comment.
Add a semicolon at the end of this line
Author
There was a problem hiding this comment.
Thank you, added a semicolon at the end.
selyafi
reviewed
Sep 17, 2026
| //num represents a randomly generated whole number between 1 and 100. | ||
|
|
||
| // Try breaking down the expression and using documentation to explain what it means | ||
| // Math.random() generates a random decimal number greater than or equal to 0 and less than 1. Multiplying it by 100 gives a number between 0 and 100. |
Author
There was a problem hiding this comment.
Gives a number between 0 and up to, but not including 100.
Thank you
selyafi
reviewed
Sep 17, 2026
| // Math.random() generates a random decimal number greater than or equal to 0 and less than 1. Multiplying it by 100 gives a number between 0 and 100. | ||
| // Math.floor() always rounds down and returns the largest integer less than or equal to a given number in this case between 0 and 99. Finally, adding 1 changes the range to 1–100. | ||
| // Math.floor(Math.random() * (maximum - minimum + 1)) | ||
| // Math.floor(Math.random() * (100 - 1 + 1) |
There was a problem hiding this comment.
A closing bracket is missing in this line
Author
There was a problem hiding this comment.
Added the missing closing bracket.
Thank you
selyafi
reviewed
Sep 17, 2026
| const age = 33; | ||
| age = age + 1; | ||
|
|
||
| let age = 33; |
There was a problem hiding this comment.
This file does not run, check age declaration
selyafi
reviewed
Sep 17, 2026
| @@ -1,9 +1,15 @@ | |||
| const cardNumber = 4533787178994213; | |||
There was a problem hiding this comment.
This file does not run. Check cardNumber and last4Digits declaration
selyafi
reviewed
Sep 17, 2026
| @@ -1,2 +1,5 @@ | |||
| const 12HourClockTime = "8:53pm"; | |||
There was a problem hiding this comment.
This file does not run. Check variable declaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1039
Changelist
Completed JavaScript fundamental tasks covering variables, assignment operators, strings, numbers, calculations, random numbers, time conversions, and objects. Also completed Chrome Console exercises.