South Africa | 26-ITP | Quentin Gwele | Sprint 1 | Form Controls - #1510
lwandogwele52-ui wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lwandogwele52-ui
added
the
Needs Review
tiakavousi
added
Review in progress
tiakavousi
left a comment
tiakavousi
left a comment
There was a problem hiding this comment.
Nice start! A few comments to help you complete the assignment:
- Please resolve all the comments
- Please add a CSS file and use it to style your HTML page, as required by the assignment.
- After pushing your changes , please add the Need Review label
| <option value="black">Black</option> | ||
| </select> | ||
| </div> | ||
| <!-- 4. T-shirt Size (6 options: XS, S, M, L, XL, XXL) --> |
There was a problem hiding this comment.
Since there are only three colour options, would radio buttons provide a better UX here? They allow users to see all available options immediately without opening a dropdown. The current is still valid for a single-choice selection.
|
|
||
| <!-- Submit Button --> | ||
| <button type="submit">Submit Order</button> | ||
| <header> |
There was a problem hiding this comment.
The <header> should come before the <main> in the document structure.
A more semantic order would be:
<header> → <main> → <footer>
This makes the page structure clearer for browsers, assistive technologies, and other tools that rely on semantic HTML.
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> |
There was a problem hiding this comment.
Please also check your <footer>: the closing </footer> tag is missing.
Also, please follow the requirement mentioned in the comment by adding a <p> element containing your name inside the footer.
tiakavousi
added
Reviewed
lwandogwele52-ui
added
the
Needs Review
tiakavousi
left a comment
tiakavousi
left a comment
There was a problem hiding this comment.
Nice work resolving the comments,
on the CSS , the form is clearly styled and the selectors are generally appropriate.
A few things to consider:
- Avoid styling all
divelements globally with A class name would be more specific and maintainable. - Consider adding a hover state to the submit button to give the user visual feedback when interacting with it.
tiakavousi
removed
the
Needs Review
|
Thanks Tia! I've refactored the global div styles to use .form-group and added a hover effect to the submit button.
… On 16 Sep 2026, at 10:35, Tia ***@***.***> wrote:
@tiakavousi commented on this pull request.
Nice work resolving the comments,
on the CSS , the form is clearly styled and the selectors are generally appropriate.
A few things to consider:
Avoid styling all div elements globally with A class name would be more specific and maintainable.
Consider adding a hover state to the submit button to give the user visual feedback when interacting with it.
—
Reply to this email directly, view it on GitHub <#1510?email_source=notifications&email_token=CFBVDQVLQW7JH7OMBV2FXLT5PJGFLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRSGAZTSNBRGQ4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5220394148>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/CFBVDQUPHG3JD7ZXBXMG3TD5PJGFLAVCNFSNUABFKJSXA33TNF2G64TZHM4DSOJQGI2DGMRUHNEXG43VMU5TKNBTGYZTIOJXGQ32C5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/CFBVDQR2ZO5EDMCKZVZ25MT5PJGFLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRSGAZTSNBRGQ4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/CFBVDQUB477ZFKOHEL6U5AT5PJGFLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRSGAZTSNBRGQ4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.
|
lwandogwele52-ui
added
the
Needs Review
tiakavousi
added
Complete
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 similar comments
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist