West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 3 | Alam clock - #1451
Open
maryam-devio wants to merge 3 commits into
Open
maryam-devio wants to merge 3 commits into
maryam-devio wants to merge 3 commits into
Conversation
maryam-devio
added
🏕 Priority Mandatory
LonMcGregor
reviewed
Sep 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
The app has some issues you can find if you try and answer my question
| @@ -1,7 +1,35 @@ | |||
| function setAlarm() {} | |||
| function setAlarm() { | |||
| const input = document.getElementById("alarmSet"); | |||
There was a problem hiding this comment.
What should happen if an alarm is already counting down?
Author
There was a problem hiding this comment.
Thanks you I updated it so that if an alarm is already counting down, the existing timer is cleared before starting the new alarm. I also tested setting a new alarm while one was running, and it resets to the new time.
LonMcGregor
added
Reviewed
maryam-devio
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
maryam-devio
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
LonMcGregor
reviewed
Sep 16, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
The alarm clock now handles what to do if an alarm is already in use. What about validation? Have you tested to see how it responds to invalid inputs?
LonMcGregor
added
the
Reviewed
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task CYF-1098
Changelist
Built the alarm clock countdown.
Formatted the time as mm:ss.
Added alarm sound when the timer reaches 00:00.
Added a background colour change when the alarm finishes.
Added support for stopping the alarm sound.