Skip to content

London | 26-ITP-Sep | Ebrahim Moqbel | sprint 2 | course work - #1420

Open
Ebrahim-Moqbel wants to merge 8 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:coursework-sprint-2
Open

Ebrahim-Moqbel wants to merge 8 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:coursework-sprint-2

Conversation

@Ebrahim-Moqbel

@Ebrahim-Moqbel Ebrahim-Moqbel commented Aug 10, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1083

Changelist

completed the debug , implement and interpret file buy building the functions and interpreting the requirements of the test cases.

Questions

N/A

@Ebrahim-Moqbel Ebrahim-Moqbel added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Aug 10, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2026
Comment thread Sprint-2/implement/lookup.test.js
Comment on lines -23 to -24
expect(parseQueryString("key")).toEqual({ key: "" });
expect(parseQueryString("key=")).toEqual({ key: "" });

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was your thinking when removing these two test assertions?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test was throwing an error of this two cases. I deleted them and forget to write them back.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like you still haven't written these in - are you still planning to use them or no?

Comment thread Sprint-2/implement/tally.test.js Outdated
Comment thread Sprint-2/interpret/invert.js
Comment thread Sprint-2/interpret/invert.js

@Poonam-raj Poonam-raj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and one question from my side in the feedback. Some great work here though

@Poonam-raj Poonam-raj added Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Complete Volunteer to add when work is complete and all review comments have been addressed. labels Aug 12, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel changed the title London | 26-ITP-May | Ebrahim Moqbel | sprint 2 | course work London | 26-ITP-Sep | Ebrahim Moqbel | sprint 2 | course work Sep 4, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Sep 10, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 14, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 17, 2026

@Poonam-raj Poonam-raj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one additional question left in the reply for the querystring test

@Ebrahim-Moqbel

Copy link
Copy Markdown
Author

Thank you I have updated the test and the function accordingly

@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 18, 2026
@Poonam-raj

Copy link
Copy Markdown

thanks Ebrahim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants