feat(java): detect unescaped dataset-derived value embedded in chart tooltip/URL image-map generators (CWE-79) - #163
Open
ai-anant wants to merge 1 commit into
Conversation
…RL generator (CWE-79)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a rule for the Jenkins
java/tree:codevigilant.java.jenkins.xss.chart-generator-unescaped-formatDetects the generic vulnerable shape:
A chart image-map tooltip/URL generator (CategoryToolTipGenerator / CategoryURLGenerator rendered by JFreeChart / hudson.util.Graph) passes a non-literal, dataset-derived row/build display name (getColumnKey / getRowKey / getDisplayName) into String.format() or string concatenation without HTML-escaping. The resulting string is emitted into an HTML image map (
<map><area title=... href=...>) that Stapler injects into the served page. A crafted display name containing quotes or markup breaks out of the attribute and yields stored XSS (CWE-79).java/jenkins/xss/semgrep --validate --config java/testcases/java/pos_chart_tooltip_xss.java(fires),testcases/java/neg_chart_tooltip_xss.java(silent)No disclosure concerns: describes the code shape only.