feat(java): detect secret/token-returning method results passed directly to a logger (CWE-532) - #157
Open
ai-anant wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects a logger call whose message (or message argument) is the return value of a method whose name indicates it yields a secret (token / secret / password / key / credential / authorization / bearer). Writing a live credential or bearer token to the server log exposes it at rest, where non-privileged operators and log-collection/aggregation systems can read it, enabling credential disclosure (CWE-532). Logs should carry only redacted/sanitized indicators.
Rule:
codevigilant.java.jenkins.logging.secret-token-call-log(newjava/jenkins/logging/tree)Validated with semgrep --validate; fires on a
LOG.finest("Auth token: " + authData.authorizationToken())repro, silent on a logger that receives only string/primitive args or pre-masked constants.