feat(java): detect CredentialsStore authorizing via global ACL or forced SYSTEM auth (CWE-862) - #142
Closed
ai-anant wants to merge 1 commit into
Closed
Conversation
…ced SYSTEM auth (CWE-862)
Author
|
Closing this lower PR in the stacked branch series: its rule content is fully contained in the newer see PR #143 (superset), which is a strict superset. Merging the newer PR delivers all rules once; keeping this separate PR would double-ship them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New generic Jenkins security rule.
Pattern (generic):
A
CredentialsStoresubclass (extendsCredentialsStore) that eitherJenkins.getInstance().getACL().hasPermission(...)/Jenkins.getInstance().hasPermission(...)instead of the owning ItemGroup/folder ACL, and/orACL.SYSTEMauthentication into agetCredentials*/data-retrieval call.Why it matters: the store's authorization surface is then enforced against the top-level Jenkins ACL only, independent of the item/folder the store was created for, and the data path is force-satisfied with SYSTEM privileges even when the caller holds only the checked global permission. A principal holding that global permission can enumerate/obtain credential objects belonging to another item scope, bypassing folder and per-credential authorization (CWE-862).
Fix guidance: consult the owner ACL (
((ACLContext) getContext()).getACL()) and pass the caller'sAuthentication, neverACL.SYSTEM, on retrieval paths.Validated with
semgrep --validate; fires on a vulnerable-store repro and does not fire on a sanitized owner-ACL/store repro.