feat(java): detect secret-typed Jenkins config fields stored as plain String instead of hudson.util.Secret (CWE-256) - #140
Open
ai-anant wants to merge 1 commit into
Conversation
… String instead of hudson.util.Secret (CWE-256)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Java/Jenkins rule detecting plugin configuration and credential classes that declare a secret-bearing value (service-account token, password, API/private key, JWT, client secret, etc., identified via field name) as a plain
java.lang.Stringrather thanhudson.util.Secret.Such String fields are persisted verbatim to
config.xml/credential XML on disk and echoed back by Stapler getters, leaving the credential readable from disk, backups, and the config UI. The fix is to store the value ashudson.util.Secret.Rule:
codevigilant.java.jenkins.authz.plaintext-secret-string-fieldtransient,static final,final, and literal-initialized fields to cut common false positivessemgrep --validate; fires on a minimal positive repro and stays silent on a Secret-typed negative repro.