chore: auto-merge timestamp-only contract-monitor refreshes - #107
Merged
Merged
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project
.github/workflows/ci.yml(maintenance/CI)Why it belongs
The contract-monitor job in
ci.ymlopens weekly "auto-fix URL drift" PRs for evidence refresh indocs/evidence-urls.json. Two problems surfaced during review:mainrequires verified commit signatures (required_signatures: trueon classic branch protection — verified via the protection API; thegh api .../rulesetsendpoint returns no rulesets). The interim timestamp-only "direct commit to main" step fails on every run withGH006: Protected branch update failed ... Commits must have verified signatures, leaving the weekly 06:00 cron broken since PR chore: split contract-monitor auto-fix by drift class #106 merged.This change restores the merge path the way GitHub's signature rule accepts it:
canonical_url_fix_count == '0'): the peter-evans PR (commits signed viasign-commits: true, exactly the pattern already proven by the merged chore: auto-fix URL drift detected by contract monitor #102) is auto-merged the same week withgh pr merge --auto --squash --delete-branch— the GitHub-signed squash merge satisfies the signature rule, andallow_auto_mergeis already enabled. No human needed for routine evidence maintenance; recursion eliminated.canonical_url_fix_count != '0'): the PR stays open for human review and is labeledneeds:semantic-review, matching the body text's own requirement.Quality evidence
yaml.safe_loadpasses on the edited workflow.canonical_url_fix_count,timestamp_refresh_count,pull-request-number); no script changes, no behaviour change to--check-expiry(issues) orcron-health.dependabot-auto-merge.ymlandrelease.ymluntouched.required_signatures: true, no rulesets, no required status checks, no required reviews.Checklist
CRITERIA.md/CONTRIBUTING.mdfor this repo.github/advisory-baseline.jsonor.github/repo-exceptions.jsonyaml.safe_load) — CI will run the full battery