fix(routes): unify not-found boundaries - #1240
Merged
mftee merged 2 commits intoAug 26, 2026
Merged
Conversation
|
@kilodesodiq-arch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@kilodesodiq-arch is attempting to deploy a commit to the Mftee's projects Team on Vercel. A member of the Team first needs to authorize it. |
mftee
approved these changes
Aug 26, 2026
mftee
left a comment
Contributor
There was a problem hiding this comment.
No merge conflicts with main. Unifying not-found boundaries across routes is a good consistency fix - approving.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1173
Closes #1170
Closes #1171
Closes #1172
Unifies the root, locale, and document-specific not-found boundaries around one shared branded presentation while preserving translated copy in the locale boundary. Boundaries without locale context use the default English copy instead of maintaining a second inconsistent visual implementation.
Why
The three not-found boundaries duplicated markup and diverged in layout, link styling, and messaging. Centralizing the structure removes that drift while keeping the locale boundary's existing
next-intlmessage source and the document boundary's distinct missing-anchor explanation.What was built
frontend/components/NotFoundContent.tsxfrontend/app/not-found.tsxfrontend/app/[locale]/not-found.tsxnotFoundmessages.frontend/app/(protected)/documents/[id]/not-found.tsxfrontend/test-utils/not-found.test.tsxIntegration changes outside
frontend/components/frontend/app/not-found.tsx— replaced duplicated root markup with the shared presentation.frontend/app/[locale]/not-found.tsx— retained locale-aware message lookup while using the shared presentation.frontend/app/(protected)/documents/[id]/not-found.tsx— replaced the divergent document-specific markup with the shared presentation.Acceptance criteria coverage
frontend/components/NotFoundContent.tsx, all three boundary files, andfrontend/test-utils/not-found.test.tsx— root/default, locale/translated, and document-specific render coverage)Deliberately deferred
None.
Test plan
npm test— not run per requestnpm run typecheck— not run per requestnpm run lint— not run per requestnpm run build— not run per requestEnv vars / Notes
No new environment variables or public API surfaces. The root and document boundaries intentionally use default English copy because those boundaries do not receive a locale parameter; the locale boundary continues to resolve
notFoundtranslations throughnext-intl.