Repository navigation
[chore/#751] 실시간 핸들러 처리 시간 메트릭 추가 - #752
Merged
Merged
Conversation
Dimo-2562
reviewed
Sep 29, 2026
| JsonNode payload = envelope.payload() == null ? NullNode.getInstance() : envelope.payload(); | ||
|
|
||
| Timer.Sample sample = Timer.start(meterRegistry); | ||
| String outcome = "success"; |
Contributor
There was a problem hiding this comment.
outcome의 의미가 조금 애매하다고 여겨집니다.
그 이유로는 handle() 메서드에서 예외가 터질 때 error로 outcome을 전환하는데, handle() 메서드 내부에서 sendError()를 호출할경우 예외가 발생하지 않으므로 예외이지만 outcome은 success입니다!
이 부분을 명확하게 개선하면 좋겠습니다!
Contributor
Author
There was a problem hiding this comment.
좋은 피드백 감사합니다!
router가 handler에 넘기는 responder를 감싸 오류 응답 전송 여부를 기록하도록 바꿨고, 태그 의미를 둘로 나누어 개선하였습니다.
- outcome(success/error): 요청자가 실제로 받은 결과 기준 - handler가 보낸 오류 응답도 error
- exception: router까지 전파된 예외
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
코드 개선 전 성능을 수치화 하기 위해 처리 시간 메트릭을 추가합니다.
연결된 issue
연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #751
✅ 체크리스트