Repository navigation
[refactor/#694] MemberExercise 참조 방향 및 도메인 네이밍 정리 - #747
Merged
Merged
Conversation
kanghana1
reviewed
Sep 14, 2026
kanghana1
left a comment
kanghana1
left a comment
Contributor
There was a problem hiding this comment.
고생하셨습니다! 추가로 중요한 건 아니지만, MemberExercise를 ExerciseParticipation으로 리네이밍 하셨는데 에러코드는 MEMBER_EXERCISE_NOT_FOUND 이거 그대로인 거 같아서 통일해주시면 좋을 거 같습니다!!
| @Param("exerciseId") Long exerciseId); | ||
|
|
||
| @Modifying | ||
| @Modifying(flushAutomatically = true) |
Contributor
There was a problem hiding this comment.
@Modifying 벌크 삭제에 flushAutomatically만 있고 clearAutomatically가 없어, 같은 트랜잭션에서 이미 로딩된 ExerciseParticipation/exercise.participations를 이후 재조회하면 1차 캐시의 stale 값이 반환될 수 있을 거 같습니다!
Contributor
Author
a43b9c0 에서 반영하였습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
MemberExercise를ExerciseParticipation으로 변경하고 운동 참여의 소유권과 삭제 책임을 exercise 도메인 기준으로 정리했습니다.기존 API와
member_exercise테이블은 유지합니다.변경 내용
Member의 운동 참여 역방향 연관관계 제거연결된 issue
close #694
🩷 Approve 하기 전 확인해주세요!
ExerciseParticipationCleanupService.prepareMemberHardDelete(memberId)를Member삭제 전에 같은 삭제 흐름에서 호출해야 합니다.member_exercise테이블은 변경하지 않았습니다.✅ 체크리스트