Repository navigation
fix: preserve caller tabs during handle refresh - #239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshing a closed task tab could adopt another caller's blank target, and duplicate cleanup could close compatible peer tabs. This repair requires canonical matching caller custody before reuse or cleanup, persists replacement handles, and reports explicit cleanup-attempt evidence.
Closes #175. Supersedes the refresh implementation in #184 while preserving its branch. P207 records the bounded source outcome and separate Standards/Spec review. PR #191 remains separate.
Validation: the installed baseline reproduced peer adoption; the source candidate passed a disposable two-subject shared-browser workflow covering replacement persistence, canonical compatible reuse, caller-owned duplicate cleanup and peer preservation, followed by zero test-process residue. Seven existing Rust test bodies passed against unchanged production helper bodies and current Service Model types. Format, strict workspace Clippy, service-client contracts, API/MCP parity, docs build, documentation links and active planning audit passed.
Limits: the full CLI focused unit binary compilation hit its 4 GiB cgroup cap before tests ran; that lane is not passed. The policy-wiring checker fails an unchanged baseline assertion for a direct policy 0047 link. CI is disabled. The candidate was smoke-only; production was not upgraded. Failed resource and fixture attempts remain recorded in the plan and runbook.