Repository navigation
fix: bound flow review recovery and reuse valid evidence - #7
Merged
Merged
Conversation
jhihweijhan
marked this pull request as ready for review
October 29, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Truncated review material can be mistaken for exhausted correction rounds. Define bounded recovery separately from finding correction while retaining delivery-only synchronization and evidence reuse.
Keep one independent reviewer responsible for each complete feature scope. Preserve raw attempts outside the final passing record, bind test reuse to recorded inputs, and persist unattended request budgets across generated commits.
Evidence
b17df83selected safe recovery but explicitly found correction counting and reviewer continuity ambiguous. This did not reproduce premature stopping.After: Four added raw cases and separate rubrics cover material recovery, retry limits, partial/changing inputs and repeated preparation. Independent initial nine-case evaluation matched the intended decisions; follow-up findings were corrected and the final focused four-case review passed.
d6cdd124d9191890afd1b9f06a6c04fef24d1706, compared withb17df8308b674704f9c0aab13cd4db434609e2c4.PYTHONDONTWRITEBYTECODE=1 npm test: 20 Node tests passed; 52 Python tests completed successfully with 13 local skips. Required CI ran all 20 Node and 52 Python tests successfully without skips, with pinned parsers and both Python versions.ctx_b76df59fc8ff. Final focused verification:ctx_4f92871842f3; three source SHA-256 identities matched the candidate. No blocking findings remain.policy_inputs. No such configuration was introduced here; the suggested self-invalidation case was not reproduced. This change excludes review outputs while preserving behavior-bearing test/configuration inputs.skills/flow-docs-sync/SKILL.md, bootstrap and MaintainSKILL.md, Maintain; contract, delivery triggersSKILL.md, Maintain; reviewer prompt, preparationFinal focused cases independently confirmed stale/timeout recovery, agent pushes under user credentials, attempt-history storage, and exclusion of review outputs without excluding behavior-bearing tests.
Merge Danger
Door: two-way
Instruction-only change; no checker code, schema, dependencies or workflow changes.
Blast Radius: guidance
Adopting agents change review preparation and bounded recovery behavior. Required final candidate checks and repository human approvals remain in force.