Fix box-plot selection and explorer card layout - #109
Conversation
✅ Deploy Preview for climate-ref ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change updates ensemble chart point selection and box-plot whiskers. It also changes explorer card layout, corrects sea surface salinity metadata, and adds interaction and rendering tests. ChangesEnsemble chart selection
Explorer card layout
Sea surface salinity metadata
Sequence Diagram(s)sequenceDiagram
participant Pointer
participant EnsembleChart
participant BoxPointMarkers
Pointer->>EnsembleChart: send mouseMove or touchMove
EnsembleChart->>BoxPointMarkers: inspect data-box-point bounds
BoxPointMarkers-->>EnsembleChart: return nearest marker identity
EnsembleChart->>EnsembleChart: resolve category, group, and point
EnsembleChart-->>Pointer: render highlighted point and tooltip
Merge Risk: ⚪ Minimal · up to The chart interaction, whisker rendering, explorer layout, and salinity metadata changes have no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 7 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes box-plot hover selection by choosing the nearest visible marker in screen coordinates and highlighting only its record and category. Corrects whiskers to end at observations within the 1.5×IQR fences.
Renames the salinity Taylor diagram and lets explorer cards share a collection-wide grid, removing gaps between card groups.
Validation: 289 frontend tests with coverage and 18 backend collection tests, TypeScript, Biome, and production build passed. Browser interaction has not been manually verified.
Summary by CodeRabbit
Bug Fixes
Style