Fix player state and cached track lost when task removed with nothing… - #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Player state and cached track lost when task removed with nothing playing
Problem
MusicPlaybackService.onTaskRemoved()unconditionally calledmusicPlayer.stopAndClear()whenever the app's task left Recents — even when nothing was playing.stopAndClear()wipes both the in-memory player state and the persisted session in SharedPreferences (clearPersistedPlaybackSession()), so the next app launch had nothing to restore: the player appeared closed and the last track wasn't cached, regardless of battery-optimization settings.Fix
stopAndClear()an optionalclearSessionparameter (defaulttrue, unchanged for every other call site) so the paused/idle case can stop the service without deleting the persisted session — leaving it restorable on the next launch.Files changed
app/src/main/java/com/lastwave/app/playback/MusicPlaybackService.ktapp/src/main/java/com/lastwave/app/playback/MusicPlayer.ktCHANGELOG.mdTesting
stopAndClear()call sites (explicit stop button, notification stop action, media sessiononStop) are unaffected and still clear the session as before.