fix: play downloaded tracks offline via MediaStore fallback - #38
Closed
Centurion-Rome wants to merge 2 commits into
Closed
fix: play downloaded tracks offline via MediaStore fallback#38Centurion-Rome wants to merge 2 commits into
Centurion-Rome wants to merge 2 commits into
Conversation
Resolve local downloads from Room first, then probe Music/LastWave through MediaStore.Audio (content:// URI) before falling back to remote streaming, so orphaned files still play after reinstall or cleared data. Adds READ_MEDIA_AUDIO (Android 13+) to the manifest and requests it at startup; extracts the pure resolution logic into OfflinePlaybackResolver.
Author
|
@ajisth69 why not merged, any reason? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37.
Offline playback of already-downloaded files in Music/LastWave failed whenever the Room download record was missing (reinstall, cleared data) or stale, and on Android 13+ the app could not see those files at all:
Tested: fresh install on Pixel 7 Pro, granted audio permission, played an offline FLAC from Music/LastWave with network off.