feat(packaging): Fedora preview archive and measurements (F01c) - #17
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f51a81def9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| copy_notices(Path(metadata["Dir"]), notices / key) | ||
| modules.append({"module": module, "version": version}) | ||
| frontend = [] | ||
| for item in output("npm", "ls", "--prefix", "frontend", "--omit=dev", "--all", "--parseable").splitlines(): |
There was a problem hiding this comment.
With the repository's HTML-entry Vite configuration, Vite's default module-preload polyfill is included in the production frontend and embedded in the executable, even though vite is a dev dependency. Using npm ls --omit=dev inventories only runtime packages such as React and omits Vite's license from third-party-notices, so every archive built by this helper has incomplete bundled-dependency notices. Collect notices based on code included in the generated bundle, including Vite's injected runtime, rather than excluding all dev dependencies.
Useful? React with 👍 / 👎.
1 participant
The mock desktop app can now be built into a Fedora 44 x86_64 archive with declared runtime dependencies, install/uninstall instructions, dependency notices, build metadata and a checksum. F01c adds the package builder and focused helper tests to CI; application behavior is unchanged.
The maintainer accepted the installed-app display/normal-close test on the current Fedora X11 desktop plus clean-container dependency/install/uninstall evidence for this task, and deferred search timing to C02b, where search is implemented. B01a retains clean-machine graphical launch before distribution. No clean graphical OS or game-integration compatibility is claimed.
Validation:
Measured window mapping: 0.487-0.514 seconds over three warm launches. Combined idle app/WebKit RSS: 397.8-435.4 MiB, above the unchanged proposed 250 MiB target. This is recorded as a performance limitation. Search is absent; cold startup and archive reproducibility are not claimed.
See docs/F01c-VALIDATION.md for environment, hashes, screenshot, measurement limits and the explicit acceptance adjustment. Tracks F01c in #1; other work is excluded.
Pre-PR fresh-runner validation passed in run 34550463696 at final head
f51a81def9463b50385bf1bcf7c20f1c697ba2ae. The local Codex review was repeated after the approved acceptance adjustment and found no actionable defects.Final merge evidence for
6c1e93b10117b42a7f0a7b6003dec78873fb5794:codex review --base maincompleted with no actionable defects after the final evidence-link update. Source and earlier passing desktop/build evidence are unchanged.