F01b: Add pinned desktop build and validation CI - #16
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22b868f5cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb9565d3bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Change
F01b turns the documented F01a build and test commands into a GitHub Actions gate on Ubuntu 24.04. Tracks the F01b child of #1; prerequisite PR #14 is merged. No application behavior changes.
Scope
Five files, about 130 handwritten lines. The workflow pins checkout/setup-go/setup-node by full upstream commit SHA, uses pinned project toolchains, disables dependency caches, grants only contents read, and does not persist checkout credentials. It runs for PRs, main and codex task-branch pushes so CI can be validated before opening a ready PR. Rollback: revert the workflow/docs commit.
Validation
Compatibility and data
No game, account, capture or private data is used. CI is build/test evidence, not desktop compatibility evidence. The unchanged application reuses the user-confirmed Fedora X11 window acceptance from F01a. Clean-target package and measurement evidence remain F01c.
Final-head evidence:
cb9565d3bc1e346ffbd63a4a91a6056bee053f49. Independentcodex review --base mainpassed after correcting fork-PR concurrency, adding changed-range whitespace validation, and handling unreachable force-push bases. Both final desktop runs passed: https://github.com/ChrisTitusTech/warframe-linux/actions/runs/34544576183 and https://github.com/ChrisTitusTech/warframe-linux/actions/runs/34544571962 . Go/JavaScript CodeQL scans passed. The concurrency and whitespace findings are fixed. The final evidence request is satisfied by these two runs: the GitHub API reports success and this exact head SHA for both. The validation document explicitly points to this PR for final-head evidence; earlier links preserve the intentional-failure/restoration demonstration. PR concurrency is keyed by PR number; branch pushes remain separate so unrelated forks cannot cancel required checks. Hosted CodeRabbit automatic review was skipped by policy; its CLI review completed with zero findings.