-
Notifications
You must be signed in to change notification settings - Fork 0
Define canonical processing policy snapshots #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chris0Jeky
wants to merge
1
commit into
main
Choose a base branch
from
issue-2257/policy-snapshot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
182 changes: 182 additions & 0 deletions
182
backend/src/Taskdeck.Application/Processing/Policy/ProcessingPolicySnapshot.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,182 @@ | ||
| using System.Buffers; | ||
| using System.Collections.Immutable; | ||
| using System.Globalization; | ||
| using System.Security.Cryptography; | ||
| using System.Text; | ||
| using System.Text.Json; | ||
| using System.Text.RegularExpressions; | ||
| using Taskdeck.Domain.Enums; | ||
|
|
||
| namespace Taskdeck.Application.Processing.Policy; | ||
|
|
||
| /// <summary> | ||
| /// The immutable constraints in force when a processing job is created. | ||
| /// CF-10 will produce snapshots; CF-03 job persistence will retain only this snapshot's digest. | ||
| /// </summary> | ||
| public sealed class ProcessingPolicySnapshot | ||
| { | ||
| public const int SchemaVersion = 1; | ||
| public const int MaxProcessorIdLength = 120; | ||
|
|
||
| private static readonly Regex ProcessorIdPattern = new("^[a-z0-9]+(?:[._-][a-z0-9]+)*$", RegexOptions.Compiled); | ||
|
Chris0Jeky marked this conversation as resolved.
|
||
|
|
||
| public ProcessingPolicySnapshot( | ||
| ProcessingEgressClass egressClass, | ||
| IEnumerable<string> allowedProcessorIds, | ||
| bool allowDiarisation, | ||
| bool allowAlignment, | ||
| DateTimeOffset? deadlineUtc, | ||
| ProcessingCostCeiling? costCeiling) | ||
| { | ||
| if (!Enum.IsDefined(egressClass)) | ||
| throw new ArgumentOutOfRangeException(nameof(egressClass), egressClass, "The egress class must be a defined ProcessingEgressClass value."); | ||
|
|
||
| ArgumentNullException.ThrowIfNull(allowedProcessorIds); | ||
| EgressClass = egressClass; | ||
| AllowedProcessorIds = CanonicalizeProcessorIds(allowedProcessorIds); | ||
| AllowDiarisation = allowDiarisation; | ||
| AllowAlignment = allowAlignment; | ||
|
|
||
| if (deadlineUtc is { Offset: var offset } && offset != TimeSpan.Zero) | ||
| throw new ArgumentException("The deadline must use a UTC offset.", nameof(deadlineUtc)); | ||
|
|
||
| DeadlineUtc = deadlineUtc; | ||
| CostCeiling = costCeiling; | ||
| } | ||
|
|
||
| public ProcessingEgressClass EgressClass { get; } | ||
|
|
||
| /// <summary> | ||
| /// An allowlist set. Input order and repeated entries do not change the policy or its digest. | ||
| /// Ordered route preferences are a future, distinct field. | ||
| /// </summary> | ||
| public ImmutableArray<string> AllowedProcessorIds { get; } | ||
|
|
||
| public bool AllowDiarisation { get; } | ||
|
|
||
| public bool AllowAlignment { get; } | ||
|
|
||
| /// <summary> | ||
| /// The absolute UTC deadline for a job, or <see langword="null"/> when the policy sets no deadline. | ||
| /// </summary> | ||
| public DateTimeOffset? DeadlineUtc { get; } | ||
|
|
||
| /// <summary> | ||
| /// The maximum charge the policy permits, or <see langword="null"/> when the policy sets no cost limit. | ||
| /// </summary> | ||
| public ProcessingCostCeiling? CostCeiling { get; } | ||
|
|
||
| public string ToCanonicalJson() => ProcessingPolicySnapshotCanonicalizer.Serialize(this); | ||
|
|
||
| public string Digest() => ProcessingPolicySnapshotCanonicalizer.Digest(this); | ||
|
|
||
| private static ImmutableArray<string> CanonicalizeProcessorIds(IEnumerable<string> allowedProcessorIds) | ||
| { | ||
| var values = new HashSet<string>(StringComparer.Ordinal); | ||
| foreach (var processorId in allowedProcessorIds) | ||
| { | ||
| if (processorId is null || processorId.Length == 0 || processorId.Length > MaxProcessorIdLength || !ProcessorIdPattern.IsMatch(processorId)) | ||
| throw new ArgumentException($"Processor IDs must be non-empty, at most {MaxProcessorIdLength} characters, and match {ProcessorIdPattern}.", nameof(allowedProcessorIds)); | ||
|
|
||
| values.Add(processorId); | ||
| } | ||
|
|
||
| return values.Order(StringComparer.Ordinal).ToImmutableArray(); | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// A currency-qualified upper bound. A bare number is deliberately not a policy value because a | ||
| /// later reader could otherwise interpret the same digest as different currencies. | ||
| /// </summary> | ||
| public sealed class ProcessingCostCeiling | ||
| { | ||
| private static readonly Regex CurrencyPattern = new("^[A-Z]{3}$", RegexOptions.Compiled); | ||
|
|
||
| public ProcessingCostCeiling(decimal amount, string currency) | ||
| { | ||
| if (amount < 0) | ||
| throw new ArgumentOutOfRangeException(nameof(amount), amount, "The cost ceiling cannot be negative."); | ||
| if (currency is null || !CurrencyPattern.IsMatch(currency)) | ||
| throw new ArgumentException("The currency must be a three-letter uppercase ISO 4217 code.", nameof(currency)); | ||
|
|
||
| Amount = amount; | ||
| Currency = currency; | ||
| } | ||
|
|
||
| public decimal Amount { get; } | ||
|
|
||
| public string Currency { get; } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Writes the ProcessingPolicySnapshot v1 byte contract. Do not replace this writer with ordinary | ||
| /// serializer options: a changed property order or date/decimal formatting changes the digest. | ||
| /// </summary> | ||
| public static class ProcessingPolicySnapshotCanonicalizer | ||
| { | ||
| private const string DigestPrefix = "sha256:"; | ||
| private const string UtcTimestampFormat = "yyyy-MM-dd'T'HH:mm:ss.fffffff'Z'"; | ||
| private const string DecimalFormat = "0.#############################"; | ||
|
|
||
| public static string Serialize(ProcessingPolicySnapshot snapshot) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(snapshot); | ||
|
|
||
| var buffer = new ArrayBufferWriter<byte>(); | ||
| using (var writer = new Utf8JsonWriter(buffer)) | ||
| { | ||
| writer.WriteStartObject(); | ||
| writer.WriteNumber("schemaVersion", ProcessingPolicySnapshot.SchemaVersion); | ||
| writer.WriteString("egressClass", StrictKebabCaseEnumConverterFactory.ToKebabCase(snapshot.EgressClass.ToString())); | ||
| writer.WritePropertyName("allowedProcessorIds"); | ||
| writer.WriteStartArray(); | ||
| foreach (var processorId in snapshot.AllowedProcessorIds) | ||
| writer.WriteStringValue(processorId); | ||
| writer.WriteEndArray(); | ||
| writer.WriteBoolean("allowDiarisation", snapshot.AllowDiarisation); | ||
| writer.WriteBoolean("allowAlignment", snapshot.AllowAlignment); | ||
| WriteDeadline(writer, snapshot.DeadlineUtc); | ||
| WriteCostCeiling(writer, snapshot.CostCeiling); | ||
| writer.WriteEndObject(); | ||
| writer.Flush(); | ||
| } | ||
|
|
||
| return Encoding.UTF8.GetString(buffer.WrittenSpan); | ||
| } | ||
|
|
||
| public static string Digest(ProcessingPolicySnapshot snapshot) | ||
| { | ||
| var json = Serialize(snapshot); | ||
| var hash = SHA256.HashData(Encoding.UTF8.GetBytes(json)); | ||
| return DigestPrefix + Convert.ToHexString(hash).ToLowerInvariant(); | ||
| } | ||
|
|
||
| private static void WriteDeadline(Utf8JsonWriter writer, DateTimeOffset? deadlineUtc) | ||
| { | ||
| writer.WritePropertyName("deadlineUtc"); | ||
| if (deadlineUtc is null) | ||
| { | ||
| writer.WriteNullValue(); | ||
| return; | ||
| } | ||
|
|
||
| writer.WriteStringValue(deadlineUtc.Value.ToString(UtcTimestampFormat, CultureInfo.InvariantCulture)); | ||
| } | ||
|
|
||
| private static void WriteCostCeiling(Utf8JsonWriter writer, ProcessingCostCeiling? costCeiling) | ||
| { | ||
| writer.WritePropertyName("costCeiling"); | ||
| if (costCeiling is null) | ||
| { | ||
| writer.WriteNullValue(); | ||
| return; | ||
| } | ||
|
|
||
| writer.WriteStartObject(); | ||
| writer.WritePropertyName("amount"); | ||
| writer.WriteRawValue(costCeiling.Amount.ToString(DecimalFormat, CultureInfo.InvariantCulture), skipInputValidation: true); | ||
| writer.WriteString("currency", costCeiling.Currency); | ||
| writer.WriteEndObject(); | ||
| } | ||
| } | ||
159 changes: 159 additions & 0 deletions
159
backend/tests/Taskdeck.Application.Tests/Processing/ProcessingPolicySnapshotTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| using System.Text.Json; | ||
| using FluentAssertions; | ||
| using Taskdeck.Application.Processing.Policy; | ||
| using Taskdeck.Domain.Enums; | ||
| using Xunit; | ||
|
|
||
| namespace Taskdeck.Application.Tests.Processing; | ||
|
|
||
| public sealed class ProcessingPolicySnapshotTests | ||
| { | ||
| private const string ExpectedCanonicalJson = """ | ||
| {"schemaVersion":1,"egressClass":"approved-destinations","allowedProcessorIds":["provider.cloud-speech","taskdeck.whisperx"],"allowDiarisation":true,"allowAlignment":false,"deadlineUtc":"2026-09-08T12:34:56.1230000Z","costCeiling":{"amount":1.5,"currency":"GBP"}} | ||
| """; | ||
|
|
||
| [Fact] | ||
| public void CanonicalJsonAndDigest_ShouldMatchTheV1GoldenBytes() | ||
| { | ||
| var snapshot = CreateBaseline(); | ||
|
|
||
| snapshot.ToCanonicalJson().Should().Be(ExpectedCanonicalJson); | ||
| snapshot.Digest().Should().Be("sha256:2f874cb048ee092d6a78e3075f37fef8254827a0cc1b3e6fa7bdfc80f0d4c9b5"); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Allowlist_ShouldBeOrdinalSortedAndDeduplicatedBeforeHashing() | ||
| { | ||
| var baseline = CreateBaseline(); | ||
| var reorderedAndRepeated = new ProcessingPolicySnapshot( | ||
| ProcessingEgressClass.ApprovedDestinations, | ||
| ["taskdeck.whisperx", "provider.cloud-speech", "taskdeck.whisperx"], | ||
| allowDiarisation: true, | ||
| allowAlignment: false, | ||
| deadlineUtc: new DateTimeOffset(2026, 9, 8, 12, 34, 56, 123, TimeSpan.Zero), | ||
| costCeiling: new ProcessingCostCeiling(1.5000m, "GBP")); | ||
|
|
||
| reorderedAndRepeated.AllowedProcessorIds.Should().Equal("provider.cloud-speech", "taskdeck.whisperx"); | ||
| reorderedAndRepeated.ToCanonicalJson().Should().Be(baseline.ToCanonicalJson()); | ||
| reorderedAndRepeated.Digest().Should().Be(baseline.Digest()); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Constructor_ShouldCopyTheCallerAllowlist() | ||
| { | ||
| var source = new[] { "taskdeck.whisperx" }; | ||
| var snapshot = new ProcessingPolicySnapshot( | ||
| ProcessingEgressClass.LocalOnly, | ||
| source, | ||
| allowDiarisation: false, | ||
| allowAlignment: false, | ||
| deadlineUtc: null, | ||
| costCeiling: null); | ||
|
|
||
| source[0] = "provider.cloud-speech"; | ||
|
|
||
| snapshot.AllowedProcessorIds.Should().Equal("taskdeck.whisperx"); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void CanonicalJson_ShouldWriteExplicitNullLimits() | ||
| { | ||
| var snapshot = new ProcessingPolicySnapshot( | ||
| ProcessingEgressClass.LocalOnly, | ||
| Array.Empty<string>(), | ||
| allowDiarisation: false, | ||
| allowAlignment: false, | ||
| deadlineUtc: null, | ||
| costCeiling: null); | ||
|
|
||
| snapshot.ToCanonicalJson().Should().Be(""" | ||
| {"schemaVersion":1,"egressClass":"local-only","allowedProcessorIds":[],"allowDiarisation":false,"allowAlignment":false,"deadlineUtc":null,"costCeiling":null} | ||
| """); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Digest_ShouldChangeWhenAnyPolicyFieldChanges() | ||
| { | ||
| var baseline = CreateBaseline(); | ||
| var variants = new[] | ||
| { | ||
| new ProcessingPolicySnapshot(ProcessingEgressClass.LocalOnly, baseline.AllowedProcessorIds, true, false, baseline.DeadlineUtc, baseline.CostCeiling), | ||
| new ProcessingPolicySnapshot(baseline.EgressClass, ["taskdeck.whisperx"], true, false, baseline.DeadlineUtc, baseline.CostCeiling), | ||
| new ProcessingPolicySnapshot(baseline.EgressClass, baseline.AllowedProcessorIds, false, false, baseline.DeadlineUtc, baseline.CostCeiling), | ||
| new ProcessingPolicySnapshot(baseline.EgressClass, baseline.AllowedProcessorIds, true, true, baseline.DeadlineUtc, baseline.CostCeiling), | ||
| new ProcessingPolicySnapshot(baseline.EgressClass, baseline.AllowedProcessorIds, true, false, baseline.DeadlineUtc!.Value.AddTicks(1), baseline.CostCeiling), | ||
| new ProcessingPolicySnapshot(baseline.EgressClass, baseline.AllowedProcessorIds, true, false, baseline.DeadlineUtc, new ProcessingCostCeiling(1.6m, "GBP")) | ||
| }; | ||
|
|
||
| variants.Should().OnlyContain(snapshot => snapshot.Digest() != baseline.Digest()); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void CanonicalDigest_ShouldNotDependOnAnAmbientJsonSerializerOptionsInstance() | ||
| { | ||
| var snapshot = CreateBaseline(); | ||
| var ambient = new JsonSerializerOptions { WriteIndented = true, PropertyNamingPolicy = JsonNamingPolicy.SnakeCaseLower }; | ||
|
|
||
| JsonSerializer.Serialize(snapshot, ambient).Should().NotBe(snapshot.ToCanonicalJson()); | ||
| snapshot.Digest().Should().Be(ProcessingPolicySnapshotCanonicalizer.Digest(snapshot)); | ||
| snapshot.ToCanonicalJson().Should().Be(ProcessingPolicySnapshotCanonicalizer.Serialize(snapshot)); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("Taskdeck.WhisperX")] | ||
| [InlineData("taskdeck..whisperx")] | ||
| [InlineData(" taskdeck.whisperx")] | ||
| [InlineData("")] | ||
| public void Constructor_ShouldRejectAmbiguousProcessorIds(string processorId) | ||
| { | ||
| var action = () => new ProcessingPolicySnapshot( | ||
| ProcessingEgressClass.LocalOnly, | ||
| [processorId], | ||
| allowDiarisation: false, | ||
| allowAlignment: false, | ||
| deadlineUtc: null, | ||
| costCeiling: null); | ||
|
|
||
| action.Should().Throw<ArgumentException>(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Constructor_ShouldRejectUndefinedEgressAndNonUtcDeadline() | ||
| { | ||
| var undefinedEgress = () => new ProcessingPolicySnapshot( | ||
| (ProcessingEgressClass)99, | ||
| Array.Empty<string>(), | ||
| false, | ||
| false, | ||
| null, | ||
| null); | ||
| var nonUtcDeadline = () => new ProcessingPolicySnapshot( | ||
| ProcessingEgressClass.LocalOnly, | ||
| Array.Empty<string>(), | ||
| false, | ||
| false, | ||
| new DateTimeOffset(2026, 9, 8, 12, 0, 0, TimeSpan.FromHours(1)), | ||
| null); | ||
|
|
||
| undefinedEgress.Should().Throw<ArgumentOutOfRangeException>(); | ||
| nonUtcDeadline.Should().Throw<ArgumentException>(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void CostCeiling_ShouldRejectNegativeAmountAndNonCanonicalCurrency() | ||
| { | ||
| var negativeAmount = () => new ProcessingCostCeiling(-0.01m, "GBP"); | ||
| var lowerCaseCurrency = () => new ProcessingCostCeiling(1m, "gbp"); | ||
|
|
||
| negativeAmount.Should().Throw<ArgumentOutOfRangeException>(); | ||
| lowerCaseCurrency.Should().Throw<ArgumentException>(); | ||
| } | ||
|
|
||
| private static ProcessingPolicySnapshot CreateBaseline() => new( | ||
| ProcessingEgressClass.ApprovedDestinations, | ||
| ["taskdeck.whisperx", "provider.cloud-speech"], | ||
| allowDiarisation: true, | ||
| allowAlignment: false, | ||
| deadlineUtc: new DateTimeOffset(2026, 9, 8, 12, 34, 56, 123, TimeSpan.Zero), | ||
| costCeiling: new ProcessingCostCeiling(1.5000m, "GBP")); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.