Preserve focus across card presentation transition - #2799
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Chris0Jeky
left a comment
Chris0Jeky
left a comment
There was a problem hiding this comment.
Independent review: no blocking findings.
The inspector-to-modal watcher only moves focus when it is outside CardModal and no nested modal owns it. It preserves editor focus and nested-dialog ownership, while the original opener remains the close-restoration target. Focused component tests (37), typecheck, and scoped lint pass at 163590a6303e1141fbefc914df3c0fc1b46b9a88.
The existing automated Codex comment only reports that its review is running; it is informational and has no finding to action. Browser evidence for the concrete transition remains pending the shared runtime lease.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 163590a630
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Session wrap-up: source and browser regression are pushed at 9ce3794. The worktree was removed after clean tracked/upstream checks; the full viewport PNG and trace are preserved at C:\Users\Public\codex-shell-home\taskdeck-artifacts\2090-inspector-modal-focus. Runtime ports 5025/4185 are stopped. Hosted checks remain to be refreshed; the tracked P2 has a resolved discussion and is retained on #2090. Handoff: PR #2802. |
|
Independent Terra review, round 1 — no confirmed Critical/High findings at head 9ce3794 against base 8d7cd7d. The existing Codex P2 is correctly triaged as a separately tracked shell-palette return-focus lifecycle defect; it is not a merge blocker for this CardModal transition. Local evidence: npx vitest --run --maxWorkers=2 src/tests/components/CardModal.spec.ts (37 passed). No fix batch required; ci-required still had Windows API Integration running at review snapshot. |
1 participant
Summary
When an open desktop inspector changes to modal presentation, CardModal now moves focus into the modal when focus is outside the card and preserves focus already owned by the card or a nested dialog. Closing still restores the original invoking control.
Validation
npx vitest --run --maxWorkers=2 src/tests/components/CardModal.spec.ts(37 passed)npm run typecheck(passed)npm run lint(passed; 8 existing warnings, 0 errors)Refs #2090