Skip to content

fix(review): scope refusal state to its board - #2797

Open
Chris0Jeky wants to merge 2 commits into
mainfrom
issue-2214/scope-refusal-state
Open

fix(review): scope refusal state to its board#2797
Chris0Jeky wants to merge 2 commits into
mainfrom
issue-2214/scope-refusal-state

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Scope refusal state to its board

The Review queue previously retained board B's access-refused panel when the reviewer switched to board C and C's first list request failed with a non-403 error. The panel made a false claim about C. Refusal state now records the board whose request received the 403, clears only when another board becomes the request target, and resumes a permission-paused poll for that new board.

The existing same-board 403 retry and generation guards remain unchanged. A new regression covers B 403 -> C 500 and verifies C reports an ordinary failure without inheriting B's access refusal.

Refs #2214

Validation

  • npx vitest --run --maxWorkers=2 src/tests/composables/useReviewProposals.spec.ts -t "does not carry a revoked board claim" (red before fix, green after)
  • npx vitest --run --maxWorkers=2 src/tests/composables/useReviewProposals.spec.ts (179 passed)
  • npm run typecheck
  • npx eslint src/composables/useReviewProposals.ts src/tests/composables/useReviewProposals.spec.ts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T00:16:31.778672Z 13ad222 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Independent review at 13ad222: no confirmed HIGH or CRITICAL findings. Verified the B 403 -> C 500 handoff, generation/supersession guards, same-board retry behavior, and re-armed poll lifetime; the scope transition clears only the stale B authority claim. Focused spec: 179 passed; typecheck and scoped ESLint pass.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13ad222047

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/composables/useReviewProposals.ts
@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 8, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Independent Terra review, round 1 — no confirmed Critical/High finding at head 869e592, live base 8d7cd7d (merge base 2fd93d6). The existing Codex P2 is correctly tracked on #2214 and is non-blocking under the bounded gate. Local evidence: npx vitest --run --maxWorkers=2 src/tests/composables/useReviewProposals.spec.ts (179 passed). No fix batch required.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

CI triage update (round 1 complete): E2E Smoke failed in review-queue-recovery.spec.ts:61. The Playwright artifact shows that, after an A -> B scope change and the second explicit intercepted 403, paper-review-access-revoked-retry is absent. At this head, loadProposalsWithOutcome clears the previous revoked state when the requested scope differs before it issues B's read; the next 403 is therefore treated as a first refusal and does not set retry feedback. The durable revoked-access panel remains visible. This is a confirmed MEDIUM feedback regression, not a flaky/unavailable-log conclusion; it is outside the C/H-only one-fix-batch rule. CI is red and this PR is parked pending a separately scoped repair/re-gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

1 participant