ci: observe nightly coordinator against complete run pairs - #2791
ci: observe nightly coordinator against complete run pairs#2791Chris0Jeky wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1493089ceb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Independent HIGH-severity review at 02df894: no confirmed HIGH or CRITICAL findings. Confirmed: the observer remains non-gating; all 12 deep suites and both schedules remain unconditional. Baseline acceptance binds same-repository/main successful Nightly and Quality runs, full required job sets at the latest attempt, run/head/tree, a bounded exact JSON artifact, ancestry, and changed-file evidence; unavailable or inconsistent data produces a full-sweep receipt. The connector P2 is real and belongs on #2334: after more than 200 successful runs per workflow, bounded pagination refuses partial history and permanently chooses full sweep. This cannot create false qualification or suppress execution in this observation-only PR, so it is non-blocking and needs no new issue. Focused exact-head checks passed: node --test scripts/ci/smart-ci/nightly-baseline.test.mjs scripts/ci/smart-ci/nightly-coordinator.test.mjs (35/35); node scripts/ci/smart-ci/action-pins.mjs --check (156/156 pinned). Hosted exact-head CI and required maintainer control-plane review remain pending. |
Chris0Jeky
left a comment
Chris0Jeky
left a comment
There was a problem hiding this comment.
Terra fresh-context independent review: no confirmed CRITICAL or HIGH finding in the exact head c086e47. The observer validates same-repository/main successful runs, complete latest-attempt real-job sets, a single bounded head/tree-bound receipt artifact, and ancestry/diff identity; unavailable or inconsistent evidence selects a full sweep. Hosted rollup is SUCCESS with zero unresolved threads. This is R4 CI control, so it remains parked pending the maintainer own review required by ADR-0066 SC-10; no merge authority is inferred from this review or green CI.
1 participant
Summary
CI Nightly now records the existing Smart CI coordinator's plan beside the full unconditional nightly jobs. The observer accepts a baseline only when authenticated Actions metadata proves that CI Nightly and Nightly Quality Signals both completed successfully on the same
mainhead, every canonical real job completed successfully on the latest attempt, and the prior plan receipt matches that run's head and Git tree.This is the CI10-2 observation vertical. It does not add job-level selection: both schedules and all twelve deep suites remain unconditional while the one-week observation evidence accumulates.
Implementation
complete: true; the plan itself never grants completionVerification
node --test scripts/ci/smart-ci/*.test.mjs— 144 passed$env:BASH_BIN = 'C:\Program Files\Git\bin\bash.exe'; node --test --test-name-pattern='pins|bootstrap boundary|checksum verifier' scripts/ci/actionlint-bootstrap.test.mjs— 5 passednode scripts/ci/smart-ci/action-pins.mjs --check— 156/156 external references SHA-pinned, 0 unpinnednode --check scripts/ci/smart-ci/nightly-baseline.mjsnode --check scripts/ci/smart-ci/nightly-coordinator.mjsgit diff --check origin/main...HEADThe R4 proving gate remains the hosted run on this exact PR head. Local Actionlint was unavailable; the repository's static bootstrap contract passed and hosted CI must prove the workflow syntax.
Docs and follow-ups
Canonical STATUS / MASTERPLAN / TESTING updates remain coordinator-owned after this observer is accepted. The quiet-night receipt, one-week observation, later selective gate, weekly full sweep, release qualification, and clean-tag proof remain open under #2334. Mutation scheduling, release workflows, repository settings, and runners are unchanged.
Refs #2334
Coordinator record: docs and the open maintainer-review checkpoint are included at 02df894. ADR-0066 requires maintainer review for this new control-plane PR after independent review and exact-head hosted qualification. Full #2334 acceptance remains open.