Skip to content

Fix: selection toolbar turns transparent after tapping More #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chethan616 merged 2 commits into from
Sep 26, 2026
Merged

Fix: selection toolbar turns transparent after tapping More #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2af9f7c
Selection toolbar: per-page glass so the overflow menu stays frosted
Chethan616 Sep 26, 2026
9f57970
Merge branch 'main' into fix/selection-toolbar-glass
Chethan616 Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions app/src/main/java/com/chethan616/clearpdf/ui/selection/PdfSelectionToolbar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,6 @@ fun PdfSelectionToolbar(
if (shown) GlassMotion.pop() else GlassMotion.settle(),
label = "selToolbarScale"
)
val radius by animateDpAsState(
if (page == ToolbarPage.Overflow) 22.dp else 24.dp, GlassMotion.settle(), label = "selToolbarRadius"
)

// Accessibility: announce the selection size politely whenever it changes.
// Computed only once a gesture settles, so a drag doesn't rebuild the text every frame.
Expand Down Expand Up @@ -305,24 +302,25 @@ fun PdfSelectionToolbar(

Layout(
content = {
// ONE glass surface for every page. Only its size animates (SizeTransform with the
// morph spring) while the pages cross-fade inside it: the capsule visibly stretches
// into the menu instead of being swapped for a second piece of glass.
// Each page carries its own glass (a single shared glass node on the animating
// container went see-through once it morphed into the menu). The pages still grow
// out of the same edge and cross-fade on the morph spring, so it reads as one
// surface stretching into the next.
AnimatedContent(
targetState = page,
modifier = Modifier.viewerGlass(backdrop, glass, shape = { RoundedRectangle(radius) }),
contentAlignment = BiasAlignment(alignH, alignV),
transitionSpec = {
val origin = TransformOrigin(if (anchorEnd) 1f else 0f, if (placedAbove) 1f else 0f)
(fadeIn(GlassMotion.fade()) + scaleIn(GlassMotion.morph(), initialScale = 0.92f, transformOrigin = origin)) togetherWith
(fadeOut(spring(stiffness = Spring.StiffnessMediumLow * 2f)) + scaleOut(GlassMotion.settle(), targetScale = 0.96f, transformOrigin = origin)) using
SizeTransform(clip = true) { _, _ -> GlassMotion.morph() }
SizeTransform(clip = false) { _, _ -> GlassMotion.morph() }
},
label = "selToolbarMorph"
) { p ->
when (p) {
ToolbarPage.Main -> Row(
Modifier
.viewerGlass(backdrop, glass, shape = { RoundedRectangle(24.dp) })
.height(48.dp)
.padding(horizontal = 4.dp),
verticalAlignment = Alignment.CenterVertically
Expand All @@ -334,6 +332,7 @@ fun PdfSelectionToolbar(
}
ToolbarPage.Overflow -> Column(
Modifier
.viewerGlass(backdrop, glass, shape = { RoundedRectangle(22.dp) })
.widthIn(min = 200.dp, max = 280.dp)
.verticalScroll(rememberScrollState())
.padding(vertical = 6.dp)
Expand All @@ -343,6 +342,7 @@ fun PdfSelectionToolbar(
}
ToolbarPage.Colors -> Row(
Modifier
.viewerGlass(backdrop, glass, shape = { RoundedRectangle(24.dp) })
.height(48.dp)
.padding(horizontal = 4.dp)
.semantics { contentDescription = colorL },
Expand Down
Loading