Repository navigation
Fix waveform tile height and restore v1 rate-map colours - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waveforms left roughly 14 px of blank space above and below because the shader used only 78% of the available voltage range. Use the full tile height, including the waveform-only view, with the same geometry for rendering and split gestures.
Restore waveform-v1’s exact five spatial rate-map colours and bin thresholds by default. Add a saved “Rate-map colour steps” setting (2–32), apply it to copied plots, and align bin edges to device pixels to prevent extra blended shades.
Validation: production build, ESLint, 17 unit tests and 13 targeted Playwright tests passed. Browser coverage includes full-height waveform pixels, split/undo interactions, plot copies, resizing, exact palette colours, and saving/restoring/resetting colour steps.