Repository navigation
Wait for workspace edits before checking restored tiles - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace browser test inspected restored tiles using a five-second assertion while Undo was still running. On a slower Actions run this failed the deployment despite the app correctly reporting that it was busy.
Wait for the existing workspace-ready signal after each undo/redo before scrolling and checking the results. This preserves the tile, history and export assertions and leaves application code unchanged.
Validation: all three workspace scenarios passed in three consecutive runs (9/9), including tetrode switching, undo/redo, export and the /waveform/ asset path.