Skip to content

refactor: use american english spelling - #235

Merged
ChelseaKR merged 2 commits into
mainfrom
docs/american-english
Sep 18, 2026
Merged

ChelseaKR merged 2 commits into
mainfrom
docs/american-english

Conversation

@ChelseaKR

Copy link
Copy Markdown
Owner

Summary

Converts British spellings to American English across ledger's hand-written source, comments, user-facing strings, docs and templates, per the owner rule of 2026-09-18 ("all apps in my portfolio should use american english everywhere, both in code and in user-facing text").

  • Converted: about 409 spellings in 142 files (behaviour, colour, labelled, honoured, catalogue, licence, recognised, judgement, neighbour, serialise, and others).
  • Identifiers renamed (internal only, so no alias is needed): 13 test functions, dualcontrol._CANCELLED → _CANCELED, tools/real_corpus.CORPUS_LICENCE → CORPUS_LICENSE, the i18n key rec_catalogue_heading → rec_catalog_heading, and some local variables.
  • i18n: the msgids "Catalogue metadata" and "…not an honour-system promise…" changed. messages.pot was re-extracted, the msgid was updated in all four .po files (en msgstr too), and the .mo files were recompiled (make i18n G13 passes). The es/fr/ar translations are unchanged.
  • Generated output: docs/accessibility/ACR.md changed along with ledger.acr_gen, and make acr-check confirms the two are still byte-identical.

Kept British spellings, with reasons (78, plus 27 aria-labelledby)

Where Count Reason
docs/adr/* 28 Accepted ADRs are immutable except for status (ADR 0001).
docs/data/real-corpus/*.json 38 Committed real-corpus evidence: external OPF corpus data, including paths like calibre 0.8.57 (a proper noun).
"licence" key in tools/real_corpus.py + tests/test_real_corpus_evidence.py 2 This is a field of the committed evidence JSON. Renaming it would break check_evidence. The key has a one-line comment.
"cancelled" proposal status (dualcontrol.py value + docstring, 2 test asserts) 4 Persisted in existing dual-control proposal stores. The constant is now _CANCELED, the stored value stays the same, and there is a one-line comment.
`cancelled` in workflow comments / CHANGELOG 4 GitHub's check-run conclusion literal.
docs/MULTIYEAR-PLAN.md "not yet labelled" 2 Verbatim quote of an ADR 0010 heading.
aria-labelledby 27 HTML/ARIA attribute name from the spec.
fr/es/ar msgstr n/a Non-English text (for example, French "catalogue" and "utilise").

Migrations/aliases: none needed. The only persisted identifiers ("cancelled" and "licence") keep their stored spelling.

Verification

  • make verify passed locally: lint, mypy, 2035 tests, i18n (POT current, MO current, parity), accessibility, acr-check, audit, claims, hygiene, workflow-lint. On this machine osv, semgrep and secret-scan defer to CI.
  • The repo's pre-commit hooks (ruff check/format, gitleaks, whitespace/EOL/YAML) passed on every changed file.

Prepared with AI assistance; reviewed before submission.

Convert British spellings to American English across hand-written source,
comments, user-facing strings, docs and templates (owner rule, 2026-09-18).

Identifiers renamed: test function names, the dual-control status constant
(_CANCELED), tools/real_corpus.py's CORPUS_LICENSE, and the i18n key
rec_catalog_heading. The "Catalog metadata" and "honor-system" msgids were
re-extracted into messages.pot, updated in every .po, and the .mo files
recompiled. docs/accessibility/ACR.md follows acr_gen and stays byte-identical.

Kept on purpose: the persisted "cancelled" proposal status, the "licence" key
of the committed real-corpus evidence JSON, GitHub's `cancelled` conclusion
literal, accepted ADRs (immutable per ADR 0001), the real-corpus evidence
data, aria-labelledby, and non-English translations.
@ChelseaKR
ChelseaKR merged commit 95e744f into main Sep 18, 2026
18 checks passed
@ChelseaKR
ChelseaKR deleted the docs/american-english branch September 18, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant