ci: rustfmt drift + run only criterion benches — main red since June - #2
Merged
Merged
Conversation
…nce June
Two unrelated failures made every CI run red since the first commit:
`cargo fmt --check` (menu.rs / lib.rs drifted from rustfmt) and the bench
job, where `cargo bench --workspace -- --quick` also runs markdusk-app's
lib unit tests under the libtest harness, which rejects `--quick`
("Unrecognized option"). `--benches` limits the job to the criterion
targets (harness = false), which accept the flag. cargo fmt applied.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Claude-Session: https://claude.ai/code/session_01RicgHjbdeNb3ZGA6DMYMfS
Same red run, third cause: clippy 1.90 flags the nested if in the launch-arg capture; edition 2024 let-chains make it one condition, no behaviour change. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01RicgHjbdeNb3ZGA6DMYMfS
--benches still includes every lib target with the default bench = true, so markdusk-app's unit tests ran under libtest and rejected --quick again. Scope the job to the crate that owns the criterion benches. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01RicgHjbdeNb3ZGA6DMYMfS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cargo fmt --allapplied (menu.rs, lib.rs had drifted), and the bench job runscargo bench --workspace --benches -- --quickso only the criterion targets (harness = false) run; the old invocation also ran markdusk-app's lib unit tests under the libtest harness, which rejects--quick("Unrecognized option").Why
Every CI run on
mainhas been red since the first commit (runs 1 and 2, June/July) on exactly these two jobs, and #1 (the landing page + discoverability kit) inherits the red. This is the fix #1 depends on; nothing else changes.Proof
cargo fmt --all -- --checkclean locally. Therustandbenchjobs on this PR are the runnable check.🤖 Generated with Claude Code
https://claude.ai/code/session_01RicgHjbdeNb3ZGA6DMYMfS
Generated by Claude Code