Skip to content

fix: eliminate shell injection in Telegram notify steps #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmnisal merged 1 commit into from
Sep 25, 2026
Merged

fix: eliminate shell injection in Telegram notify steps #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 50 additions & 34 deletions .github/workflows/build-deploy-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,29 +23,37 @@ jobs:

steps:
- name: Notify Build Start
run: |
curl -s -X POST https://api.telegram.org/bot${{ secrets.DEV_ACTIONS_BOT_TOKEN }}/sendMessage \
-d chat_id="${{ secrets.DEV_ACTIONS_GROUP_ID }}" \
-d text="
${{ env.PROJECT_NAME }} Build Started 🚀
📁 Repository: ${{ github.repository }}
👤 Initiator: ${{ github.actor }}
🕒 Timestamp: ${{ github.event.head_commit.timestamp}}
📝 Commit Message: ${{ github.event.head_commit.message }}"
env:
TELEGRAM_BOT_TOKEN: ${{ secrets.DEV_ACTIONS_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.DEV_ACTIONS_GROUP_ID }}
COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
COMMIT_TIMESTAMP: ${{ github.event.head_commit.timestamp }}
run: |
curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
--data-urlencode "chat_id=${TELEGRAM_CHAT_ID}" \
--data-urlencode "text=${PROJECT_NAME} Build Started 🚀
📁 Repository: ${GITHUB_REPOSITORY}
👤 Initiator: ${GITHUB_ACTOR}
🕒 Timestamp: ${COMMIT_TIMESTAMP}
📝 Commit Message: ${COMMIT_MESSAGE}"

- name: Checkout Code
uses: actions/checkout@v4

- name: Notify Build Complete
env:
TELEGRAM_BOT_TOKEN: ${{ secrets.DEV_ACTIONS_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.DEV_ACTIONS_GROUP_ID }}
COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
COMMIT_TIMESTAMP: ${{ github.event.head_commit.timestamp }}
run: |
curl -s -X POST https://api.telegram.org/bot${{ secrets.DEV_ACTIONS_BOT_TOKEN }}/sendMessage \
-d chat_id="${{ secrets.DEV_ACTIONS_GROUP_ID }}" \
-d text="
${{ env.PROJECT_NAME }} Code Checked Out �
📁 Repository: ${{ github.repository }}
👤 Initiator: ${{ github.actor }}
🕒 Timestamp: ${{ github.event.head_commit.timestamp }}
📝 Commit Message: ${{ github.event.head_commit.message }}"
curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
--data-urlencode "chat_id=${TELEGRAM_CHAT_ID}" \
--data-urlencode "text=${PROJECT_NAME} Code Checked Out 📦
📁 Repository: ${GITHUB_REPOSITORY}
👤 Initiator: ${GITHUB_ACTOR}
🕒 Timestamp: ${COMMIT_TIMESTAMP}
📝 Commit Message: ${COMMIT_MESSAGE}"

# ✅ Check if .git directory exists remotely
- name: Check if Git Exists on Server
Expand Down Expand Up @@ -148,26 +156,34 @@ jobs:
sudo systemctl status ${{ env.SERVICE_NAME }} --no-pager

- name: Notify Deploy Complete
env:
TELEGRAM_BOT_TOKEN: ${{ secrets.DEV_ACTIONS_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.DEV_ACTIONS_GROUP_ID }}
COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
COMMIT_TIMESTAMP: ${{ github.event.head_commit.timestamp }}
run: |
curl -s -X POST https://api.telegram.org/bot${{ secrets.DEV_ACTIONS_BOT_TOKEN }}/sendMessage \
-d chat_id="${{ secrets.DEV_ACTIONS_GROUP_ID }}" \
-d text="
${{ env.PROJECT_NAME }} Deploy Complete ✅
📁 Repository: ${{ github.repository }}
👤 Initiator: ${{ github.actor }}
🕒 Timestamp: ${{ github.event.head_commit.timestamp }}
📝 Commit Message: ${{ github.event.head_commit.message }}"
curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
--data-urlencode "chat_id=${TELEGRAM_CHAT_ID}" \
--data-urlencode "text=${PROJECT_NAME} Deploy Complete ✅
📁 Repository: ${GITHUB_REPOSITORY}
👤 Initiator: ${GITHUB_ACTOR}
🕒 Timestamp: ${COMMIT_TIMESTAMP}
📝 Commit Message: ${COMMIT_MESSAGE}"

- name: Notify Deploy Failure
if: failure()
env:
TELEGRAM_BOT_TOKEN: ${{ secrets.DEV_ACTIONS_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.DEV_ACTIONS_GROUP_ID }}
COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
COMMIT_TIMESTAMP: ${{ github.event.head_commit.timestamp }}
run: |
curl -s -X POST https://api.telegram.org/bot${{ secrets.DEV_ACTIONS_BOT_TOKEN }}/sendMessage \
-d chat_id="${{ secrets.DEV_ACTIONS_GROUP_ID }}" \
-d text="
❌ ${{ env.PROJECT_NAME }} Deploy Failed!
📁 Repository: ${{ github.repository }}
👤 Initiator: ${{ github.actor }}
🕒 Timestamp: ${{ github.event.head_commit.timestamp }}
📝 Commit Message: ${{ github.event.head_commit.message }}

curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
--data-urlencode "chat_id=${TELEGRAM_CHAT_ID}" \
--data-urlencode "text=❌ ${PROJECT_NAME} Deploy Failed!
📁 Repository: ${GITHUB_REPOSITORY}
👤 Initiator: ${GITHUB_ACTOR}
🕒 Timestamp: ${COMMIT_TIMESTAMP}
📝 Commit Message: ${COMMIT_MESSAGE}

Please check the GitHub Actions logs for more details."
84 changes: 50 additions & 34 deletions .github/workflows/build-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,29 +22,37 @@ jobs:

steps:
- name: Notify Build Start
run: |
curl -s -X POST https://api.telegram.org/bot${{ secrets.DEV_ACTIONS_BOT_TOKEN }}/sendMessage \
-d chat_id="${{ secrets.DEV_ACTIONS_GROUP_ID }}" \
-d text="
${{ env.PROJECT_NAME }} Build Started 🚀
📁 Repository: ${{ github.repository }}
👤 Initiator: ${{ github.actor }}
🕒 Timestamp: ${{ github.event.head_commit.timestamp}}
📝 Commit Message: ${{ github.event.head_commit.message }}"
env:
TELEGRAM_BOT_TOKEN: ${{ secrets.DEV_ACTIONS_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.DEV_ACTIONS_GROUP_ID }}
COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
COMMIT_TIMESTAMP: ${{ github.event.head_commit.timestamp }}
run: |
curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
--data-urlencode "chat_id=${TELEGRAM_CHAT_ID}" \
--data-urlencode "text=${PROJECT_NAME} Build Started 🚀
📁 Repository: ${GITHUB_REPOSITORY}
👤 Initiator: ${GITHUB_ACTOR}
🕒 Timestamp: ${COMMIT_TIMESTAMP}
📝 Commit Message: ${COMMIT_MESSAGE}"

- name: Checkout Code
uses: actions/checkout@v4

- name: Notify Build Complete
env:
TELEGRAM_BOT_TOKEN: ${{ secrets.DEV_ACTIONS_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.DEV_ACTIONS_GROUP_ID }}
COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
COMMIT_TIMESTAMP: ${{ github.event.head_commit.timestamp }}
run: |
curl -s -X POST https://api.telegram.org/bot${{ secrets.DEV_ACTIONS_BOT_TOKEN }}/sendMessage \
-d chat_id="${{ secrets.DEV_ACTIONS_GROUP_ID }}" \
-d text="
${{ env.PROJECT_NAME }} Code Checked Out �
📁 Repository: ${{ github.repository }}
👤 Initiator: ${{ github.actor }}
🕒 Timestamp: ${{ github.event.head_commit.timestamp }}
📝 Commit Message: ${{ github.event.head_commit.message }}"
curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
--data-urlencode "chat_id=${TELEGRAM_CHAT_ID}" \
--data-urlencode "text=${PROJECT_NAME} Code Checked Out 📦
📁 Repository: ${GITHUB_REPOSITORY}
👤 Initiator: ${GITHUB_ACTOR}
🕒 Timestamp: ${COMMIT_TIMESTAMP}
📝 Commit Message: ${COMMIT_MESSAGE}"

# ✅ Check if .git directory exists remotely
- name: Check if Git Exists on Server
Expand Down Expand Up @@ -148,26 +156,34 @@ jobs:
sudo systemctl status ${{ env.SERVICE_NAME }} --no-pager

- name: Notify Deploy Complete
env:
TELEGRAM_BOT_TOKEN: ${{ secrets.DEV_ACTIONS_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.DEV_ACTIONS_GROUP_ID }}
COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
COMMIT_TIMESTAMP: ${{ github.event.head_commit.timestamp }}
run: |
curl -s -X POST https://api.telegram.org/bot${{ secrets.DEV_ACTIONS_BOT_TOKEN }}/sendMessage \
-d chat_id="${{ secrets.DEV_ACTIONS_GROUP_ID }}" \
-d text="
${{ env.PROJECT_NAME }} Deploy Complete ✅
📁 Repository: ${{ github.repository }}
👤 Initiator: ${{ github.actor }}
🕒 Timestamp: ${{ github.event.head_commit.timestamp }}
📝 Commit Message: ${{ github.event.head_commit.message }}"
curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
--data-urlencode "chat_id=${TELEGRAM_CHAT_ID}" \
--data-urlencode "text=${PROJECT_NAME} Deploy Complete ✅
📁 Repository: ${GITHUB_REPOSITORY}
👤 Initiator: ${GITHUB_ACTOR}
🕒 Timestamp: ${COMMIT_TIMESTAMP}
📝 Commit Message: ${COMMIT_MESSAGE}"

- name: Notify Deploy Failure
if: failure()
env:
TELEGRAM_BOT_TOKEN: ${{ secrets.DEV_ACTIONS_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.DEV_ACTIONS_GROUP_ID }}
COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
COMMIT_TIMESTAMP: ${{ github.event.head_commit.timestamp }}
run: |
curl -s -X POST https://api.telegram.org/bot${{ secrets.DEV_ACTIONS_BOT_TOKEN }}/sendMessage \
-d chat_id="${{ secrets.DEV_ACTIONS_GROUP_ID }}" \
-d text="
❌ ${{ env.PROJECT_NAME }} Deploy Failed!
📁 Repository: ${{ github.repository }}
👤 Initiator: ${{ github.actor }}
🕒 Timestamp: ${{ github.event.head_commit.timestamp }}
📝 Commit Message: ${{ github.event.head_commit.message }}

curl -s -X POST "https://api.telegram.org/bot${TELEGRAM_BOT_TOKEN}/sendMessage" \
--data-urlencode "chat_id=${TELEGRAM_CHAT_ID}" \
--data-urlencode "text=❌ ${PROJECT_NAME} Deploy Failed!
📁 Repository: ${GITHUB_REPOSITORY}
👤 Initiator: ${GITHUB_ACTOR}
🕒 Timestamp: ${COMMIT_TIMESTAMP}
📝 Commit Message: ${COMMIT_MESSAGE}

Please check the GitHub Actions logs for more details."
Loading