fix: create users via the lnbits 1.x account api

[xbuddhi]

Summary

Every /start from a new Telegram user currently fails:

[createWallet] Create wallet error: Not Found
[startHandler] Error with initWallet: Not Found

Not Found is a literal 404. The bot creates users through the usermanager extension, whose last release (v0.4.1) declares max_lnbits_version: 1.0.0. The backend now runs lnbits 1.6.0, so the extension cannot be installed — and could not run if forced, since it imports get_key_type and WalletTypeInfo, both removed in 1.x.

Existing users are unaffected; their wallets already exist on the instance.

Approach

Usermanager's functionality moved into core, behind account-level auth — a wallet api key does not grant it. Rather than putting the superuser login in the bot config, this uses an ACL token scoped to /users/api/v1: it can manage accounts but cannot spend from any wallet or reach admin settings.

The token lives in its own adminHeader, separate from the wallet-key header, so wallet calls cannot present it even by accident. Paying still uses the wallet's own admin key.

Call	Before (404)	After
GetUser	POST /usermanager/api/v1/users/{id}	GET /users/api/v1/user/{id}
CreateUserWithInitialWallet	POST /usermanager/api/v1/users	POST /users/api/v1/user → fetch wallet → rename
CreateWallet	POST /usermanager/api/v1/wallets	POST /users/api/v1/user/{id}/wallet
Wallets	GET /usermanager/api/v1/wallets/{id}	GET /users/api/v1/user/{id}/wallet

Two behaviour differences are absorbed inside the client, so call sites are unchanged (internal/telegram/start.go needed no edit — its existing create-then-fetch-wallet flow already matches 1.x):

• Creating a user also creates its wallet, but names it lnbits_default_wallet_name and omits wallets from the response. So the wallet is fetched and renamed, preserving the <telegram id> (<handle>) convention the existing 1883 wallets use.
• The bot passes a telegram handle as email, which 1.x rejects via is_valid_email_address, so it is no longer sent. admin_id has no counterpart in 1.x and is now ignored (parameter kept so callers don't change).

Config

One new field. A wallet api key cannot do account management on 1.x, so this is required:

lnbits:
  admin_token: "<ACL token scoped to /users/api/v1>"

Test plan

• go build ./...
• go vet ./internal/lnbits/... ./internal/telegram/... (only a pre-existing text.go warning)
• Every call verified against the live 1.6.0 instance with a real ACL token:
  • GET /users/api/v1/user/{id} → 200
  • POST /users/api/v1/user → 200, returns id
  • GET .../{id}/wallet → 200, adminkey present, name comes back as LNbits wallet (confirming the rename is needed)
  • PATCH /api/v1/wallet → 200, renamed
• Scope confirmed: the token cannot spend (POST /api/v1/payments → 401) and cannot read admin settings (GET /admin/api/v1/settings → 403, rejected by the ACL itself)
• Probe account cleaned up; instance back to 1884 wallets / 1884 accounts / 0 orphans
• Deploy and confirm a real /start from a new Telegram user

Note: deleting a user via DELETE /users/api/v1/user/{id} soft-deletes its wallet but leaves the row with a dangling user — worth knowing if user deletion is ever automated.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 525c1b6c-07e4-4e86-95ec-cc68c3b99981

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}