Repository navigation
Conversation
lnbits 0.x serialises a payment's `time` as unix seconds and 1.x as an RFC3339 string, so moving the backend to 1.x broke transaction history with "cannot unmarshal string into Go struct field Payment.time of type int". Decode into a UnixTime that takes either form and normalises to seconds. Marshalling still emits the number, so the API responses these types are serialised into are unchanged. The webhook payload carries the same field. Nothing had failed there yet only because no deposit had arrived since the migration - a decode error on that path drops the incoming payment notification.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrating the backend from Voltage (lnbits 0.x) to Railway (lnbits 1.x) broke the bot's transaction history:
lnbits 0.x serialises a payment's
timeas unix seconds; 1.x serialises it as an RFC3339 string. The Go structs decoding those payloads declaredtimeas an integer.lnbits.UnixTime, which decodes either form and normalises to unix seconds. Marshalling still emits the number, so the API responses these types are serialised into are unchanged.Payment.Timeandwebhook.Webhook.Time.The webhook payload carries the same field. Nothing had failed there yet only because no deposit had arrived since the migration — a decode error on that path drops the incoming payment notification, so it is worth fixing in the same change.
InvoiceStreamalso declarestimeas an int but is never unmarshalled into (the handler proxies raw SSE bytes), so it is left alone.Test plan
go build ./...go test ./internal/lnbits/..."2026-09-13T11:42:41.293908+00:00"(1.x, fractional seconds) →1789299761"2026-09-13T11:42:41Z"→17892997611702411690(0.x, as in the Voltage export) → unchangednull/""→0, no error/transactionsrenders in Telegram after deployNote:
internal/telegramtests fail at init on a missingconfig.yaml; this is pre-existing and reproduces identically on a cleanmain.🤖 Generated with Claude Code