Skip to content

fix: Clicking "Try it!" welcome button on mobile closes autosave modal - #220

Open
StickmanRed wants to merge 1 commit into
developmentfrom
StickmanRed-welcome-modal-button-fix
Open

StickmanRed wants to merge 1 commit into
developmentfrom
StickmanRed-welcome-modal-button-fix

Conversation

@StickmanRed

Copy link
Copy Markdown
Collaborator

Description

So you press the "Try it!" button, which triggers an onTouchStart event. The welcome modal closes and the autosave modal opens. But because the button was a child of the overlay element, you've technically pressed the overlay. And then releasing triggers the overlay element's click event, closing the autosave modal before you have a chance to interact with it.

This fix reuses the useClickEvent property of buttons from #90 so that the click event gets captured by the "Try it!" button, not the outside overlay.

Testing

  1. Use a mobile device or emulate one using Devtools' device toolbar.
  2. Reload the Candlestick page.
  3. Click the "Try it!" button in the Welcome Modal. The autosave modal should appear after the welcome modal as expected.

Checklist

  • This PR does not make sense to split up into smaller PRs.

@StickmanRed StickmanRed added the bug Something isn't working label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant