Repository navigation
Operate the daemons with the shared instrumentctl CLI - #30
Merged
Merged
Conversation
mikelangmayr
force-pushed
the
mike/systemd-deployment
branch
from
October 12, 2026 21:55
41e3205 to
e89a459
Compare
prkrtg
approved these changes
Oct 13, 2026
| # Needs the instrument's camera_interface build in the venv, which is not a | ||
| # git dependency: pip install <lris2-camerad-instrument> | ||
| LRIS2_DAEMON=camera | ||
| LRIS2_CONFIG=/etc/lris2/rcam.yaml |
Contributor
There was a problem hiding this comment.
Looks good
I think one thing we might wanna look into is the config path is hardcoded, so if there was a need to change the location or the instrument's name we would have to change all config files
Contributor
Author
There was a problem hiding this comment.
Good catch, dropped it. The instance files now set only LRIS2_DAEMON, and the config path is derived as /.yaml, with the etc dir itself settable in instrument.toml. Needs the matching instrumentctl release before this merges, otherwise deploy still expects the variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lris2command, which comes from instrumentctl and is shared with the other instruments; all that is specific to LRIS2 issrc/cli/instrument.tomland a console scriptdoctorcan report a host whose unit predates a template change instead of it going silently stalesystemd/install.shis now only a bootstrap: it builds the venv and hands over tolris2 install. Everything after host setup needs no rootlris2@, so an instance islris2@rpressand the instance files drop the redundant prefixstatus --allresolves all three instances to their daemon scripts, anddoctordiagnoses an unconfigured host with the right remedies. The root host setup has not been run there