Repository navigation
Report write-only keywords in keys.list - #43
Merged
Merged
Conversation
scizen9
approved these changes
Oct 13, 2026
scizen9
left a comment
Collaborator
There was a problem hiding this comment.
Looks OK, but does it also handle "action" keywords?
prkrtg
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keys.readonly filters write-only ones when selecting by pattern and the keygrabber passes explicit names resolved fromkeys.list, which carried no access information.{"ok": true, "value": false}, soshutdownis archived as a datapoint that is false forever on every peer at every interval. A setter-only keyword answers with an error, so the inficon'sunits_codehas been failing every read and inflating the keygrabber'sreaderrorscounter with a fault that is not one.keys.listnow reportswriteonlyalongsidematches, andCollection.resolvesubtracts it.matchesstays complete, solibby liststill shows a trigger.keys.liston every resolve. Putting access there fixes it for every client rather than only this one; onekeys.describeper keyword would be nineteen extra round trips per refresh on atccryo alone.