Skip to content

ZSHTR-78 Added new line lists and bug fixes #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yashvi-Sharma merged 4 commits into from
Oct 15, 2026
Merged

ZSHTR-78 Added new line lists and bug fixes #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3850be0
new line lists from pyreduce atlas for lamps
Yashvi-Sharma Sep 29, 2026
0c40ab2
resolution related bug fixes
Yashvi-Sharma Oct 2, 2026
fa4096b
subpixel on by default
Yashvi-Sharma Oct 5, 2026
4c7e31e
fixed double application of atmo transmission bug
Yashvi-Sharma Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MaunaKea/MaunaKea.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ properties :
value: 22.0
unit: mag
seeing : "!OBS.seeing" # [arcsec]
skycalc_timeout : 2.0 # [seconds]
skycalc_timeout : 30.0 # [seconds]
ao_table : "ao_table.dat"
ao_enabled: False

effects :
- name : atmo_transmission # Also applies thermal emission component using !ATMO.temperature and (1-transmission)
description : Atmospheric transmission for Mauna Kea from TAPAS
class : TERCurve
class : TAPASTERCurve
include : True
kwargs:
filename: "TER_maunakea_tapas.dat"
Expand Down
8 changes: 5 additions & 3 deletions ZShooter_v2/ZShooter_SPEC.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ effects:
- 0.42
- 0.37
- 0.33
- 0.30
filename_format: "slits/slit_{:.2f}_as.dat"
current_slit: "!INST.vis_curr_slit" # as live property to allow dynamic updates
- selector_value: [3, 4, 5]
Expand All @@ -77,6 +78,7 @@ effects:
- 0.42
- 0.37
- 0.33
- 0.30
filename_format: "slits/slit_{:.2f}_as.dat"
current_slit: "!INST.nir_curr_slit" # as live property to allow dynamic updates

Expand Down Expand Up @@ -197,7 +199,7 @@ effects:
axis: y
position_unit: pix
position_min: 0
position_max: 2048
position_max: 4096
wave_unit: nm
center_wave_min: "!INST.tapered_qe_b_center_wave_min"
center_wave_max: "!INST.tapered_qe_b_center_wave_max"
Expand All @@ -213,7 +215,7 @@ effects:
axis: y
position_unit: pix
position_min: 0
position_max: 2048
position_max: 4096
wave_unit: nm
center_wave_min: "!INST.tapered_qe_g_center_wave_min"
center_wave_max: "!INST.tapered_qe_g_center_wave_max"
Expand All @@ -229,7 +231,7 @@ effects:
axis: y
position_unit: pix
position_min: 0
position_max: 2048
position_max: 4096
wave_unit: nm
center_wave_min: "!INST.tapered_qe_r_center_wave_min"
center_wave_max: "!INST.tapered_qe_r_center_wave_max"
Expand Down
6 changes: 4 additions & 2 deletions ZShooter_v2/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,10 @@ name : ZShooter_simulation_paramters
description : RC simulation paramters which need to change for a zshooter run

properties :
random :
seed : 9001
sub_pixel:
flag : True
# random :
# seed : 9001

spectral :
wave_unit : "um"
Expand Down
Loading
Loading