Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the selected June 2026 optical prescription, explicit R/H/YJ placements and the agreed omitted reddest YJ order. Configure the physical slit and shared exposure/binning path.
Part 13/29 of the Caltech review series. Review the diff against
review/xs-12-xshooter-instrument; the final destination isdev_master.Merge after series 12: irdb, series 09: scopesim.
Review focus: ZShooter_v2/ZShooter_SPEC.yaml; spectrograph prescription; slits; default.yaml.
Validation: The workspace geometry/sampling tests pass in the 188-case spectroscopy run. Reused slit/exposure and spatial-convergence checks passed in IRDB.
Source commits/snapshots:
0efb498,a31dc90,fc3e2b9,9fa8317,2e9a0ae,72d360a,75f5f1b,8c01711.Use a merge commit to preserve the stack ancestry and pinned commits. After this merges, retarget the next PR in this repository to its default branch. Do not squash/rebase an earlier stack entry without rebuilding its descendants and dependency pins.