Repository navigation
fix failure in fw location for Astier one-param fit - #34
Open
weatherhead99 wants to merge 1 commit into
Open
weatherhead99 wants to merge 1 commit into
weatherhead99 wants to merge 1 commit into
Conversation
…for unc.UFloat columns with no units
prkrtg
reviewed
Oct 21, 2026
| nomvals = list(nomvals) | ||
| errvals = list(errvals) | ||
| nomdtp = _choose_minimal_numpy_dtype(nomvals) | ||
| errdtp = _choose_minimal_numpy_dtype(errvals) |
Contributor
There was a problem hiding this comment.
Will this default to float16? Should it be float64
Contributor
Author
There was a problem hiding this comment.
it checks all values and chooses the minimal dtype that accurately represents them all
| return outcols | ||
|
|
||
|
|
||
| def _unc_column_to_fits_column( |
Contributor
There was a problem hiding this comment.
Maybe a helper would be useful here since it uses a lot of the same code in the _quantity_column_to_fits_column function
Contributor
Author
There was a problem hiding this comment.
agree, could be nice. This code will be disappearing before Christmas though since the taskresult redesign will replace a bunch of it. But i can put a helper in for now if you like.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix failure in fw location for Astier one-param fit, and add support for unc.UFloat columns with no units