Repository navigation
Vignette masking and cosmic ray masking tasks - #33
Open
Yashvi-Sharma wants to merge 4 commits into
Open
Yashvi-Sharma wants to merge 4 commits into
Yashvi-Sharma wants to merge 4 commits into
Conversation
prkrtg
reviewed
Oct 14, 2026
| Build a full mask from the individual output masks. | ||
| :return: True if a full mask was built, False otherwise. | ||
| """ | ||
| if self.masks is not None: |
Contributor
There was a problem hiding this comment.
Good fix, I think we may hit a performance issue though since now every call to rebuilds the full mask from scratch
For performance improvement we could clear the cache when output masks change
Collaborator
Author
There was a problem hiding this comment.
Yes, I'll put in something to avoid unnecessary mask rebuilding
| f"relative to the illumination level and assumes a zero-level corrected image.") | ||
| for out_id, output in img.outputs.items(): | ||
| img.outputs[out_id] = self._mask_output(output) | ||
| img.image_type.update({"vignette_masked": True}) |
Contributor
There was a problem hiding this comment.
VignetteMasking updates output.masks but never call build_full_mask() (unlike SigmaClipMasking), so img.masks goes stale, and has to read it directly
Possible fix here is to do img.image_type.update({"vignette_masked": img._build_full_mask()})
Collaborator
Author
There was a problem hiding this comment.
good catch, will fix
…proves mask rebuilding performance a bit
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two tasks in preprocessing.py following the structure of SigmaClipMasking task:
Added corresponding core functions and tests for both tasks.
Fixed minor rebase bugs.
Updated toml to include lacosmic as dependency.