Skip to content

Remove in-tree instrument submodules and the INSTRUMENT build path - #57

Merged
mikelangmayr merged 2 commits into
mainfrom
remove-in-tree-instruments
Oct 22, 2026
Merged

mikelangmayr merged 2 commits into
mainfrom
remove-in-tree-instruments

Conversation

@mikelangmayr

@mikelangmayr mikelangmayr commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
  • Remove the camerad/Instruments submodules and packaging/tracking; instruments build from their own repository with the core pulled in via FetchContent
  • Remove the INSTRUMENT and CAMERAD_PYTHON_PACKAGE CMake options; the core always builds its controller's default factory
  • Drop the instrument and submodule steps from the CMake workflow, and the ATC FITS keyword table from the docs
  • Remove the per-instrument doc pages and instrument-specific examples; instruments document themselves in their own repository
  • Update README and docs for the instrument-repo build
  • Verified: archon core build and Python import test, reference instrument build and test, hispec-tracking-camera-instrument built against this branch with its module importing, sphinx-build -W

@astronomerdave astronomerdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this is exactly what I was planning to do next. One thing though, instrument pages under docs/instruments stay in the core and I think they should be moved to each instrument's repo since the core shouldn't carry real instruments.

@mikelangmayr
mikelangmayr merged commit 2a1cd20 into main Oct 22, 2026
5 checks passed
@mikelangmayr
mikelangmayr deleted the remove-in-tree-instruments branch October 22, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants