Skip to content

Initialise the exposure mode producer and consumer flags - #55

Merged
mikelangmayr merged 1 commit into
mainfrom
initialise-exposure-mode-flags
Oct 15, 2026
Merged

mikelangmayr merged 1 commit into
mainfrom
initialise-exposure-mode-flags

Conversation

@mikelangmayr

Copy link
Copy Markdown
Contributor
  • is_producer_finished, is_producer_error and is_consumer_error had no initialiser, so a freshly constructed exposure mode started with indeterminate values.
  • They are read before a session sets them, by the reap at the start of the next one, so the indeterminate value surfaced as a failure that never happened: an abort that worked reported "abort failed".
  • Observed on the HISPEC tracking camera as an intermittent abort failure, present on roughly half of freerun runs and on every run of the autofetch and freerun combination. With the initialisers the false reports stop.

@scizen9 scizen9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikelangmayr
mikelangmayr merged commit 5028c0d into main Oct 15, 2026
5 checks passed
@mikelangmayr
mikelangmayr deleted the initialise-exposure-mode-flags branch October 15, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants