Repository navigation
Conversation
FINE_ACQUIRE_GOAL and FINE_ACQUIRE_PRECISION are parsed into fineacquire_state.goal_arcsec and prec_arcsec, which were compile-time constants. Defaults in slicecamd.cfg.in are the existing values, 0.4 and 0.35, so behaviour is unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32d62050a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| if ( config.param[entry] == "FINE_ACQUIRE_GOAL" ) { | ||
| try { this->fineacquire_state.goal_arcsec = std::stod( config.arg[entry] ); } |
There was a problem hiding this comment.
When FINE_ACQUIRE_GOAL is negative, nan, or inf, std::stod succeeds and the daemon accepts the value. In do_fineacquire, a negative/NaN goal can never satisfy the convergence comparison and there is no correction-cycle limit, while infinity marks every target as locked immediately; this can leave acquisition repeatedly commanding offsets or let observations proceed before the target reaches the slit. Require a finite, positive value before updating the state.
Useful? React with 👍 / 👎.
|
Withdrawn. These are not the limiting parameters for acquisition in poor seeing; no change needed. |
1 participant
Automatic acquisition in bad seeing requires setting the fine-acquire
convergence tolerance and scatter gate from the config file.
Both are compile-time constants in
slicecam_interface.h:goal_arcsec = 0.4prec_arcsec = 0.35Adds
FINE_ACQUIRE_GOALandFINE_ACQUIRE_PRECISION, parsed inconfigure_interfacealongside the otherFINE_ACQUIRE_*keys.Defaults in
slicecamd.cfg.inare the current values; behaviour unchanged.