Repository navigation
dyn_bike: the golden for libcvc's Jolt-fitted dyn_bike_si_of - #134
Merged
Merged
Conversation
libcvc's dyn_bike_si_of now fits the tires to how Jolt's corner (B C = 1.12 / alpha_peak, front and rear alike) and gives a direct drive no drive lag and no drag or rolling resistance. Its DynBike.Golden changed with it; this is the regenerated tests/fixtures/dyn_bike_golden.json. The torch twin reads the vehicle from the file, so it needs no change: test_dyn_bike_parity passes to 1e-9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the golden for transfix/libcvc#753, which fits libcvc's
dyn_bike_si_ofto how Jolt's vehicles drive:libcvc's
DynBike.Goldenchanged with it. This PR copies the regeneratedtests/fixtures/dyn_bike_golden.json.The torch twin (
grl_snam/dyn_bike.py) reads the vehicle from the file, so no code changes.tests/test_dyn_bike_parity.pypasses against the new golden to 1e-9 (9 passed locally).Merge together with transfix/libcvc#753.