Repository navigation
Conversation
Previously, it would repeatedly call preciousblock on the local bitcoind after each extra URL submission
There was a problem hiding this comment.
🟡 Changes recommended
The endpoint-routing bug fix lacks regression coverage.
1 open finding
What changed in this PR
Routes preciousblock to the same Bitcoin RPC endpoint used for each block submission.
Changes:
- Passes the target URL and block hash into
preciousblock. - Adds const-correctness and removes an unnecessary cast.
| File | Description |
|---|---|
src/datum_submitblock.c |
Routes preciousblock calls to local or extra submission endpoints. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| // precious block! | ||
| preciousblock(tcurl, submitblock_hash); | ||
| preciousblock(tcurl, url, block_hash_hex); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, it would repeatedly call preciousblock on the local bitcoind after each extra URL submission