[FEAT] Add a unique image mode for Dataref_water project - #1
Open
NICOLAS-GAEL wants to merge 6 commits into
Open
[FEAT] Add a unique image mode for Dataref_water project#1NICOLAS-GAEL wants to merge 6 commits into
NICOLAS-GAEL wants to merge 6 commits into
Conversation
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
image_classification() returns ImageClassifier, but that variable is only created in the shell == False branch. The default shell=True path therefore ends with UnboundLocalError. Please return a value that is defined in both branches.
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
One guard regression: (clear_date != None or unique_image != None) is always true with the default unique_image=False (and the CLI also passes "false"), so two-image mode can enter with clear_date=None and pass that into is_valid_date(). Could this require clear_date unless str2bool(unique_image) is actually true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chain has been modified to compute a mask on a single image with a configurable resolution.
Moreover one additional band, the slope, is now computed and added in the composite product generated in input by ALCD.
Some VRT files are created to consult easily the NDVI, NDWI and RGB images.
It is also possible to take samples without buffer zone around.
Processing time enhancement ("in memory" process for intermediate files, RAM parameter for OTB application, some files no more generated -contour_labels.tif, contours_superposition.png, colorized_classif.png, quicklook.png-, confidence map generation in option).