Repository navigation
fix: fixed the indep coord linkage in EDD strainanalysis - #387
Merged
rolfverberg merged 2 commits intoOct 20, 2026
Conversation
keara-soloway
left a comment
keara-soloway
left a comment
Contributor
There was a problem hiding this comment.
Does wrapping the nxprocess in an nxroot work if we want to be able to write the nxprocess back to a nexus file already containing a map nxentry without overwriting the map nxentry? I want to make sure this still supports pipelines like this strain pipeline
Contributor
Author
|
@keara-soloway Yes, wrapping into NXroot only happens in non-standalone use. In standalone use it will not wrap it and return the NXprocess directly. I fixed this in the docstring for the_get_nxprocess() method. This should still work as it did before, but we should setup a release validation test for this (had that already on my list) |
keara-soloway
approved these changes
Oct 20, 2026
rolfverberg
deleted the
381-fix-the-linkage-of-the-independent-dims-in-the-edd-strain-analysis-workflow
branch
October 21, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.