Repository navigation
feat(facets): unique collection filter choice - #2198
Merged
zzacharo merged 1 commit intoOct 29, 2026
Merged
Conversation
zzacharo
reviewed
Oct 28, 2026
| <h2 class="text-capitalize f8 mt-5"><b>{{ key }}</b></h2> | ||
| <ul class="list-unstyled" ng-init="values=getValues(key)" ng-repeat="item in value.buckets"> | ||
| <li class="cds-facets-item"> | ||
| <li class="cds-facets-item" ng-show="key !== 'collections' || !getValues(key).length || getValues(key).indexOf(item.key) > -1"> |
Contributor
There was a problem hiding this comment.
would that hide facet item when the collections key is present on the buckets? The condition is a bit complex can you maybe add a comment?
Contributor
Author
There was a problem hiding this comment.
updated the pr to use ng-hide - that logic is hopefully more readable and added a comment to explain
liptakpanna
force-pushed
the
unique-collection-filter
branch
from
October 29, 2026 09:07
806609a to
1c3d96f
Compare
liptakpanna
force-pushed
the
unique-collection-filter
branch
from
October 29, 2026 09:20
1c3d96f to
d1a6732
Compare
zzacharo
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the UI if one collection filter is selected hide the rest of them to minimize confusion. Currently, it looks like it would apply AND filter based on the numbers, but it's OR between the collections.
All records in 3 collections, one of them is in 2:
One collection filter selected, hides the other one:
If the URL has multiple collection filters, display them as active, hide the rest:
For comparison BEFORE the change: