Update stokes concatenation tests - #101
Open
markccchiang wants to merge 9 commits into
Open
Conversation
…update_concat_images_tests
…update_concat_images_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses part of issue #3. The three stokes concatenation tests ,
CONCAT_STOKES_IMAGES,CONCAT_STOKES_IMAGES_AXIS_DEGENERACY, andCONCAT_ERROR_MESSAGE, are updated, and all three are added to thefile_browserstage so that CI runs them.CONCAT_STOKES_IMAGES: concatenates the four single-stokes cubes ofIRCp10216_sci.spw0into a hypercube, in five combinations (IQUV, IV, QU, IQU, QUV). It checks the ack's name and shape, then walks the stokes axis withSET_IMAGE_CHANNELSand compares each plane against the histogram of the cube that belongs there. Each of the four inputs has a distinct histogram, so this is what identifies the planes. Every case names its files in reverse order and expects the axis back sorted, sinceStokesFilesConnectoriterates its loaders in polarization order.CONCAT_STOKES_IMAGES_AXIS_DEGENERACY: the same five combinations against thedropdegcubes, which carry no stokes axis of their own. That is the premise of the test: it sendsDoConcatdown itsstokes_axis < 0branch, where a stokes coordinate is built and every image extended before they can be joined. The inputs are now checked to really be degenerate-axis-dropped, and the planes are walked the same way.CONCAT_ERROR_MESSAGE: six requests the backend must refuse, covering every rejectionStokesFilesConnectorcan raise for theset_QAdata: inconsistent shapes, duplicate Stokes type, too few files, mixed file types, a hypercube with a gap in the stokes axis, and a missing file. Each refusal is checked to draw its message, to draw nothing else, and to leave the requested file ID free. A seventh case concatenates a valid pair afterwards, which is what exercisesClearCache.Checklist
For the pull request:
(or no documentation changes are needed)