Update d2l-dialog to prefer native dialog rendering. - #7446
Open
dbatiste wants to merge 6 commits into
Open
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dbatiste
commented
Sep 4, 2026
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <script> |
Contributor
Author
There was a problem hiding this comment.
This was not working as originally developed since previous changes were made. I've removed the double tests for the ifrau case since I don't think they are necessary for both native and custom impls.
dbatiste
commented
Sep 4, 2026
| before(() => mockFlag(preferNativeGeneralDialogsFlag, type === 'native')); | ||
| after(() => resetFlag(preferNativeGeneralDialogsFlag)); | ||
|
|
||
| const focusOnContentTestCases = (type === 'custom') ? [ |
Contributor
Author
There was a problem hiding this comment.
These test cases are only applicable in custom mode, so I've pulled them out to only run when custom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAUD-10409
This PR updates
d2l-dialogto prefer native dialog element.Like the previous PRs that similarly updated
d2l-dialog-fullscreenandd2l-dialog-confirm, this includes a change in focus behaviour. Specifically, the header is focused. (much investigation was done by Margaree #6760). Another focus behaviour difference is due to not usingd2l-focus-trap, as explained in #2424.d2l-dialog-confirmadopted that change as well, though I am not sure if we noticed.