Repository navigation
Test that wrapper help after toolchain arguments changes nothing - #5571
Conversation
Wrapper 0.2.x only treated --help/-h as help when it came right after `toolchain`, so `baml toolchain use 0.25.2 --help` changed the selection and `baml toolchain uninstall 0.25.2 --help` deleted the toolchain. Canary already prints help for these; this locks it in for both wrapper implementations and adds the test to the ci profile. Co-Authored-By: Claude <[email protected]>
|
😎 This pull request was merged. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
Binary size checks failed❌ 2 violations · ✅ 1 passed
Details & how to fixViolations:
Add/update baselines:
[artifacts.bridge_wasm]
file_bytes = 26140672
gzip_bytes = 7725978
[artifacts.packed-program]
file_bytes = 39309864
gzip_bytes = 16154526Generated by |
🤖 Claude on behalf of Antonio
Wrapper 0.2.x treated
--help/-has help only right aftertoolchain, so the flag after a selector ran the command. Outside a project, on 0.2.3:Canary already prints help in both wrappers (clap in the Rust wrapper,
management()in the BAML wrapper), but no test covered the flag after an argument. This adds a wrapper test that puts--help/-hafter the arguments ofuse,use --global,install --force,updateanduninstall, and checks that help is printed and thatBAML_HOMEand the project are unchanged. It also adds the test to theciprofile, which is the one CI runs.Summary by CodeRabbit
--helpand-hwhen placed after toolchain command arguments. The checks verify that these flags display usage information without modifying project files or contacting the release server. No user-facing behavior changes are included in this update.